From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Kiran Gunda <kgunda@codeaurora.org>,
jingoohan1@gmail.com, lee.jones@linaro.org,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
daniel.thompson@linaro.org, jacek.anaszewski@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V5 4/8] backlight: qcom-wled: Rename PM8941* to WLED3
Date: Mon, 27 Aug 2018 08:04:29 -0700 [thread overview]
Message-ID: <20180827150429.GM3048@tuxbook-pro> (raw)
In-Reply-To: <20180827100448.GF31905@amd>
On Mon 27 Aug 03:04 PDT 2018, Pavel Machek wrote:
> On Fri 2018-08-24 15:57:43, Kiran Gunda wrote:
> > Rename the PM8941* references as WLED3 to make the driver
> > generic and have WLED support for other PMICs. Also rename
> > "i_boost_limit" and "i_limit" variables to "boost_i_limit"
> > and "string_i_limit" respectively to resemble the corresponding
> > register names.
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> > -MODULE_DESCRIPTION("pm8941 wled driver");
> > +MODULE_DESCRIPTION("Qualcomm WLED driver");
>
> "... supporting pm8941, xxx devices" ?
>
I would suggest not doing this. There's quite a long list of different
PMICs containing some version of this hardware block.
Regards,
Bjorn
next prev parent reply other threads:[~2018-08-27 15:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 10:27 [PATCH V5 0/8] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-08-24 10:27 ` [PATCH V5 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-08-27 9:49 ` Pavel Machek
2018-08-24 10:27 ` [PATCH V5 2/8] backlight: qcom-wled: restructure the qcom-wled bindings Kiran Gunda
2018-08-27 9:52 ` Pavel Machek
2018-08-24 10:27 ` [PATCH V5 3/8] backlight: qcom-wled: Add new properties for PMI8998 Kiran Gunda
2018-08-27 10:01 ` Pavel Machek
2018-08-29 5:52 ` kgunda
2018-08-24 10:27 ` [PATCH V5 4/8] backlight: qcom-wled: Rename PM8941* to WLED3 Kiran Gunda
2018-08-27 10:04 ` Pavel Machek
2018-08-27 15:04 ` Bjorn Andersson [this message]
2018-08-24 10:27 ` [PATCH V5 5/8] backlight: qcom-wled: Restructure the driver for WLED3 Kiran Gunda
2018-08-27 10:09 ` Pavel Machek
2018-08-29 7:10 ` kgunda
2018-08-24 10:27 ` [PATCH V5 6/8] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-08-24 10:27 ` [PATCH V5 7/8] backlight: qcom-wled: add support for short circuit handling Kiran Gunda
2018-08-24 10:27 ` [PATCH V5 8/8] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-08-27 14:54 ` Bjorn Andersson
2018-08-29 7:13 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827150429.GM3048@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).