devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Can Guo <cang@codeaurora.org>,
	Subhash Jadavani <subhashj@codeaurora.org>,
	asutoshd@codeaurora.org, Manu Gautam <mgautam@codeaurora.org>,
	kishon <kishon@ti.com>, robh+dt <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845
Date: Thu, 30 Aug 2018 18:10:33 -0700	[thread overview]
Message-ID: <20180831011033.GN2523@minitux> (raw)
In-Reply-To: <CAFp+6iGDvt9UX8y7HCwC+QdTdyCLxuj5pNWbbttJAHGEPW+tyw@mail.gmail.com>

On Thu 30 Aug 03:44 PDT 2018, Vivek Gautam wrote:

> On Thu, Aug 30, 2018 at 11:46 AM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > On Tue 31 Jul 03:09 PDT 2018, Can Guo wrote:
> >
> > > This patch series adds support for UFS QMP PHY on SDM845 and the
> > > compatible string for it. This patch series depends on the current
> > > proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on
> > > the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also
> > > rebased on updated pipe_clk initialization sequence [3]. This series
> > > can only be merged once the dependent patches do.
> > > [1] http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html
> > > [2] http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html
> > > [3] https://patchwork.kernel.org/patch/10376551/
> > >
> >
> > Hi Can,
> >
> > We still have the issue that the older non-QMP phy driver takes a direct
> > call to ufs_qcom_phy_set_tx_lane_enable(), which means that pointing
> > UFSHCD to this phy implementation results in a kernel panic.
> 
> Hi Bjorn,
> 
> I have a series that removes couple of these function calls -
> ufs_qcom_phy_set_tx_lane_enable(), and
> ufs_qcom_phy_save_controller_version() from ufs-qcom, and
> make phy-qcom-ufs-qmp-20nm as broken.
> I can post it out if that sounds okay.
> 

That sounds really good, please do sent that out.

Regards,
Bjorn

      reply	other threads:[~2018-08-31  1:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 10:09 [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845 Can Guo
2018-07-31 10:09 ` [PATCH v8 1/5] phy: Update PHY power control sequence Can Guo
2018-07-31 10:09 ` [PATCH v8 2/5] phy: General struct and field cleanup Can Guo
2018-07-31 10:09 ` [PATCH v8 3/5] phy: Add QMP phy based UFS phy support for sdm845 Can Guo
2018-08-08 21:55   ` Evan Green
2018-08-09 17:26     ` Vivek Gautam
2018-08-09 17:59       ` Evan Green
2018-07-31 10:09 ` [PATCH v8 4/5] scsi: ufs: Power on phy after it is initialized Can Guo
2018-08-09 18:00   ` Evan Green
2018-07-31 10:09 ` [PATCH v8 5/5] dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845 Can Guo
2018-08-01  2:21 ` [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845 cang
2018-08-30  6:16 ` Bjorn Andersson
2018-08-30 10:44   ` Vivek Gautam
2018-08-31  1:10     ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180831011033.GN2523@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=asutoshd@codeaurora.org \
    --cc=cang@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mgautam@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=subhashj@codeaurora.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).