From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845 Date: Thu, 30 Aug 2018 18:10:33 -0700 Message-ID: <20180831011033.GN2523@minitux> References: <20180731100914.19856-1-cang@codeaurora.org> <20180830061604.GM2523@minitux> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Vivek Gautam Cc: Can Guo , Subhash Jadavani , asutoshd@codeaurora.org, Manu Gautam , kishon , robh+dt , Mark Rutland , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm List-Id: devicetree@vger.kernel.org On Thu 30 Aug 03:44 PDT 2018, Vivek Gautam wrote: > On Thu, Aug 30, 2018 at 11:46 AM Bjorn Andersson > wrote: > > > > On Tue 31 Jul 03:09 PDT 2018, Can Guo wrote: > > > > > This patch series adds support for UFS QMP PHY on SDM845 and the > > > compatible string for it. This patch series depends on the current > > > proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on > > > the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also > > > rebased on updated pipe_clk initialization sequence [3]. This series > > > can only be merged once the dependent patches do. > > > [1] http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html > > > [2] http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html > > > [3] https://patchwork.kernel.org/patch/10376551/ > > > > > > > Hi Can, > > > > We still have the issue that the older non-QMP phy driver takes a direct > > call to ufs_qcom_phy_set_tx_lane_enable(), which means that pointing > > UFSHCD to this phy implementation results in a kernel panic. > > Hi Bjorn, > > I have a series that removes couple of these function calls - > ufs_qcom_phy_set_tx_lane_enable(), and > ufs_qcom_phy_save_controller_version() from ufs-qcom, and > make phy-qcom-ufs-qmp-20nm as broken. > I can post it out if that sounds okay. > That sounds really good, please do sent that out. Regards, Bjorn