From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Sricharan R <sricharan@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
Craig Tatlor <ctatlor97@gmail.com>
Subject: Re: [PATCH 0/3] firmware: qcom: scm: Improve clock handling
Date: Thu, 30 Aug 2018 18:17:41 -0700 [thread overview]
Message-ID: <20180831011741.GO2523@minitux> (raw)
In-Reply-To: <153567767852.93865.5427679731919930718@swboyd.mtv.corp.google.com>
On Thu 30 Aug 18:07 PDT 2018, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2018-08-29 16:15:02)
> > We're currently facing the issue that every new platform requires the addition
> > of a compatible to the DT binding as well as the driver.
> >
> > The DT binding patch to allow us to use qcom,scm for all these new platforms
> > that doesn't require any clocks and the driver is reworked to make the qcom,scm
> > still pick up specified clocks in this case but won't require them.
> >
> > This makes it possible to add new platforms by simply add the new compatible to
> > the list in the DT binding, but no changes needs to be done in the driver.
> > Which is what is done in patch 3.
> >
>
> I still think it may be even simpler to move to the "get all the clks"
> API and then stop caring completely. Any reason to not do that?
>
I love working with drivers that tells me things like "hey you forgot to
add the 'core' clock", rather than having to spend hours bisecting which
register access it is that's causing that reboot and then try to drill
that down to a particular clock.
Apart from that, the "get-all-the-clocks" would work fine as well. Does
this API exist yet?
Regards,
Bjorn
prev parent reply other threads:[~2018-08-31 1:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 23:15 [PATCH 0/3] firmware: qcom: scm: Improve clock handling Bjorn Andersson
2018-08-29 23:15 ` [PATCH 1/3] dt-bindings: firmware: scm: Refactor compatibles and clocks Bjorn Andersson
2018-08-31 1:06 ` Stephen Boyd
2018-08-29 23:15 ` [PATCH 2/3] firmware: qcom: scm: Refactor clock handling Bjorn Andersson
2018-08-31 1:06 ` Stephen Boyd
2018-08-29 23:15 ` [PATCH 3/3] dt-bindings: firmware: scm: Add MSM8998 and SDM845 Bjorn Andersson
2018-08-31 1:07 ` Stephen Boyd
2018-08-31 1:07 ` [PATCH 0/3] firmware: qcom: scm: Improve clock handling Stephen Boyd
2018-08-31 1:17 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831011741.GO2523@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=ctatlor97@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).