From: Andrew Lunn <andrew@lunn.ch>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
john@phrozen.org, linux-mips@linux-mips.org, dev@kresin.me,
hauke.mehrtens@intel.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver
Date: Sat, 1 Sep 2018 20:12:53 +0200 [thread overview]
Message-ID: <20180901181253.GD6305@lunn.ch> (raw)
In-Reply-To: <20180901120427.9983-1-hauke@hauke-m.de>
> +struct xrx200_priv {
> + struct net_device_stats stats;
net_device has a stats structure in it. Please use that one.
Otherwise, this looks good.
Andrew
next prev parent reply other threads:[~2018-09-01 18:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 11:45 [PATCH v2 net-next 0/7] Add support for Lantiq / Intel vrx200 network Hauke Mehrtens
2018-09-01 11:45 ` [PATCH v2 net-next 1/7] MIPS: lantiq: dma: add dev pointer Hauke Mehrtens
2018-09-01 14:57 ` Andrew Lunn
2018-09-01 21:39 ` Hauke Mehrtens
2018-09-02 1:26 ` Andrew Lunn
2018-09-01 11:45 ` [PATCH v2 net-next 2/7] MIPS: lantiq: Do not enable IRQs in dma open Hauke Mehrtens
2018-09-01 12:03 ` [PATCH v2 net-next 3/7] net: dsa: Add Lantiq / Intel GSWIP tag support Hauke Mehrtens
2018-09-01 18:01 ` Andrew Lunn
2018-09-03 18:52 ` Florian Fainelli
2018-09-01 12:04 ` [PATCH v2 net-next 4/7] dt-bindings: net: Add lantiq,xrx200-net DT bindings Hauke Mehrtens
2018-09-03 19:46 ` Florian Fainelli
2018-09-04 21:54 ` Hauke Mehrtens
2018-09-01 12:04 ` [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver Hauke Mehrtens
2018-09-01 18:12 ` Andrew Lunn [this message]
2018-09-03 19:24 ` Florian Fainelli
2018-09-04 21:37 ` Hauke Mehrtens
2018-09-01 12:04 ` [PATCH v2 net-next 6/7] dt-bindings: net: dsa: Add lantiq,xrx200-gswip DT bindings Hauke Mehrtens
2018-09-01 12:05 ` [PATCH v2 net-next 7/7] net: dsa: Add Lantiq / Intel DSA driver for vrx200 Hauke Mehrtens
2018-09-01 21:44 ` Hauke Mehrtens
2018-09-03 19:54 ` Florian Fainelli
2018-09-06 21:11 ` Hauke Mehrtens
2018-09-06 21:36 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180901181253.GD6305@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dev@kresin.me \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke.mehrtens@intel.com \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).