From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default compatible string
Date: Mon, 3 Sep 2018 12:27:28 -0700 [thread overview]
Message-ID: <20180903192728.GF3456@tuxbook-pro> (raw)
In-Reply-To: <20180829125803.11227-1-niklas.cassel@linaro.org>
On Wed 29 Aug 05:58 PDT 2018, Niklas Cassel wrote:
> Add a default compatible string.
> This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt
> and matches how it's done in arch/arm64/boot/dts/qcom/msm8916.dtsi
>
> Usually the dts overrides this compatible property, however, if the dts
> doesn't specify a compatible, this compatible string will be used.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
I think we should just say that the board dts must specify a compatible.
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index cd3865e7a270..354d3f900f72 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -17,6 +17,7 @@
>
> / {
> model = "Qualcomm Technologies, Inc. MSM8996";
> + compatible = "qcom,msm8996";
>
> interrupt-parent = <&intc>;
>
> --
> 2.17.1
>
prev parent reply other threads:[~2018-09-03 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 12:58 [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default compatible string Niklas Cassel
2018-08-29 12:58 ` [PATCH 2/2] arm64: dts: db820c: Add qcom,apq8096 to " Niklas Cassel
2018-09-03 19:27 ` Bjorn Andersson
2018-09-03 19:27 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903192728.GF3456@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).