From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 1/4] clk: sunxi-ng: Enable DE2_CCU for SUN8I and SUN50I Date: Wed, 5 Sep 2018 09:03:35 +0200 Message-ID: <20180905070335.dclhpxjld4vdkdu4@flea> References: <20180904163609.10171-1-jagan@amarulasolutions.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bycakrqk56pgt6ts" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20180904163609.10171-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jagan Teki Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Michael Turquette , Stephen Boyd , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Trimarchi , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --bycakrqk56pgt6ts Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Tue, Sep 04, 2018 at 10:06:06PM +0530, Jagan Teki wrote: > Allwinner SoC like SUN8I and SUN50I has DE2 CCU so enable them > as default. > > Signed-off-by: Jagan Teki > --- > Changes for v4, v3: > - none > Changes for v2: > - Enable for MACH_SUN8I > > drivers/clk/sunxi-ng/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig > index 826674d090fd..e20182aa9748 100644 > --- a/drivers/clk/sunxi-ng/Kconfig > +++ b/drivers/clk/sunxi-ng/Kconfig > @@ -63,6 +63,8 @@ config SUN8I_V3S_CCU > > config SUN8I_DE2_CCU > bool "Support for the Allwinner SoCs DE2 CCU" > + default MACH_SUN8I || (ARM64 && ARCH_SUNXI) > + depends on DRM_SUN4I && (MACH_SUN8I || (ARM64 && ARCH_SUNXI)) I don't see why there's a dependency on the DRM driver. I'm pretty sure this would even break simplefb. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --bycakrqk56pgt6ts--