From: Andi Shyti <andi@etezian.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, marco.franchi@nxp.com,
fabio.estevam@nxp.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux-imx@nxp.com
Subject: Re: [PATCH 1/2] input: egalax_ts: add system wakeup support
Date: Wed, 5 Sep 2018 13:34:28 +0300 [thread overview]
Message-ID: <20180905103428.GA29158@jack.zhora.eu> (raw)
In-Reply-To: <1536139607-16848-1-git-send-email-Anson.Huang@nxp.com>
Hi Anson,
On Wed, Sep 05, 2018 at 05:26:46PM +0800, Anson Huang wrote:
> This patch adds wakeup function support for egalax touch
> screen, if "wakeup-source" is added to device tree's egalax
> touch screen node, the wakeup function will be enabled, and
> egalax touch screen will be able to wakeup system from suspend.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
I think you messed up the order of the patches, this patch
whould come after the PATCH 2/2.
You first create the property and then use it. If someone checks
out right here, he would find an inconsistency between the dts
property and this code.
You can either send a version 2 with the correct order or check
if Dmitry and Rob are willing to sync for who takes first the
patch first.
Andi
next prev parent reply other threads:[~2018-09-05 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 9:26 [PATCH 1/2] input: egalax_ts: add system wakeup support Anson Huang
2018-09-05 9:26 ` [PATCH 2/2] dt-bindings: egalax-ts: add support for wakeup event action Anson Huang
2018-09-16 22:54 ` Rob Herring
2018-09-17 18:07 ` Dmitry Torokhov
2018-09-19 1:01 ` Rob Herring
2018-09-05 10:34 ` Andi Shyti [this message]
2018-09-05 17:27 ` [PATCH 1/2] input: egalax_ts: add system wakeup support Dmitry Torokhov
2018-09-06 3:30 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905103428.GA29158@jack.zhora.eu \
--to=andi@etezian.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.franchi@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).