* [RFT] ARM: dts: exynos: Remove double SD card detect pin inversion
@ 2018-09-05 17:40 ` Krzysztof Kozlowski
2018-09-06 9:21 ` Marek Szyprowski
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2018-09-05 17:40 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Maciej Purski, Simon Shields,
Sylwester Nawrocki, Marek Szyprowski, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
The SDHCI standard, MMC host controller bindings and MMC core defines
card detect pin as active low. Therefore there is no point to invert it
twice.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Tested only on Odroid U3. Tests on other platforms would be appreciated.
---
arch/arm/boot/dts/exynos4210-universal_c210.dts | 3 +--
arch/arm/boot/dts/exynos4412-midas.dtsi | 3 +--
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +--
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 4e6ff97e1ec4..249bfbff1e20 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -537,8 +537,7 @@
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
pinctrl-names = "default";
vmmc-supply = <&ldo5_reg>;
- cd-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>;
- cd-inverted;
+ cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
status = "okay";
};
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
index c0476c290977..aed2f2e2b0d1 100644
--- a/arch/arm/boot/dts/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
@@ -1269,8 +1269,7 @@
&sdhci_2 {
bus-width = <4>;
- cd-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>;
- cd-inverted;
+ cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sdhci2_cd>;
pinctrl-names = "default";
vmmc-supply = <&ldo21_reg>;
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index a09e46c9dbc0..2caa3132f34e 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -539,8 +539,7 @@
pinctrl-names = "default";
vmmc-supply = <&ldo21_reg>;
vqmmc-supply = <&ldo4_reg>;
- cd-gpios = <&gpk2 2 GPIO_ACTIVE_HIGH>;
- cd-inverted;
+ cd-gpios = <&gpk2 2 GPIO_ACTIVE_LOW>;
status = "okay";
};
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFT] ARM: dts: exynos: Remove double SD card detect pin inversion
2018-09-05 17:40 ` [RFT] ARM: dts: exynos: Remove double SD card detect pin inversion Krzysztof Kozlowski
@ 2018-09-06 9:21 ` Marek Szyprowski
0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2018-09-06 9:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, Maciej Purski, Simon Shields,
Sylwester Nawrocki, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Hi Krzysztof,
On 2018-09-05 19:40, Krzysztof Kozlowski wrote:
> The SDHCI standard, MMC host controller bindings and MMC core defines
> card detect pin as active low. Therefore there is no point to invert it
> twice.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Tested only on Odroid U3. Tests on other platforms would be appreciated.
SD card detection still works fine on UniversalC210, Trats2 and OdroidU3
with this patch.
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 3 +--
> arch/arm/boot/dts/exynos4412-midas.dtsi | 3 +--
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +--
> 3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> index 4e6ff97e1ec4..249bfbff1e20 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -537,8 +537,7 @@
> pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
> pinctrl-names = "default";
> vmmc-supply = <&ldo5_reg>;
> - cd-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>;
> - cd-inverted;
> + cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index c0476c290977..aed2f2e2b0d1 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -1269,8 +1269,7 @@
>
> &sdhci_2 {
> bus-width = <4>;
> - cd-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>;
> - cd-inverted;
> + cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
> pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sdhci2_cd>;
> pinctrl-names = "default";
> vmmc-supply = <&ldo21_reg>;
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index a09e46c9dbc0..2caa3132f34e 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -539,8 +539,7 @@
> pinctrl-names = "default";
> vmmc-supply = <&ldo21_reg>;
> vqmmc-supply = <&ldo4_reg>;
> - cd-gpios = <&gpk2 2 GPIO_ACTIVE_HIGH>;
> - cd-inverted;
> + cd-gpios = <&gpk2 2 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-06 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180905174039epcas3p2091bb7ef6c51b2850ea774e6d76b7f5d@epcas3p2.samsung.com>
2018-09-05 17:40 ` [RFT] ARM: dts: exynos: Remove double SD card detect pin inversion Krzysztof Kozlowski
2018-09-06 9:21 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).