From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stafford Horne Subject: Re: [PATCH 10/21] openrisc: use for_each_of_cpu_node iterator Date: Thu, 6 Sep 2018 18:12:09 +0900 Message-ID: <20180906091209.GJ4594@lianli.shorne-pla.net> References: <20180905193738.19325-1-robh@kernel.org> <20180905193738.19325-11-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180905193738.19325-11-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Bonn , Stefan Kristiansson , openrisc@lists.librecores.org List-Id: devicetree@vger.kernel.org On Wed, Sep 05, 2018 at 02:37:27PM -0500, Rob Herring wrote: > Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This > has the side effect of defaulting to iterating using "cpu" node names in > preference to the deprecated (for FDT) device_type == "cpu". > > This also fixes a leaked reference for cpus node. > > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openrisc@lists.librecores.org > Signed-off-by: Rob Herring > --- > Please ack and I will take via the DT tree. This is dependent on the > first 2 patches. > > arch/openrisc/kernel/setup.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c > index 9d28ab14d139..e17fcd83120f 100644 > --- a/arch/openrisc/kernel/setup.c > +++ b/arch/openrisc/kernel/setup.c > @@ -158,9 +158,8 @@ static struct device_node *setup_find_cpu_node(int cpu) > { > u32 hwid; > struct device_node *cpun; > - struct device_node *cpus = of_find_node_by_path("/cpus"); > > - for_each_available_child_of_node(cpus, cpun) { > + for_each_of_cpu_node(cpun) { > if (of_property_read_u32(cpun, "reg", &hwid)) > continue; > if (hwid == cpu) This looks fine to me. Thanks Rob Acked-by: Stafford Horne