From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: msm8996: Drop model
Date: Thu, 6 Sep 2018 08:56:14 -0700 [thread overview]
Message-ID: <20180906155614.GC3286@tuxbook-pro> (raw)
In-Reply-To: <20180905183517.9390-4-niklas.cassel@linaro.org>
On Wed 05 Sep 11:35 PDT 2018, Niklas Cassel wrote:
> DTS board files should always specify model and compatible.
>
> All DTS board files that includes msm8996.dtsi
> already specifies model and compatible, and will thus
> override the model and compatible in msm8996.dtsi.
>
> Drop model from msm8916.dtsi, since it is only a source of confusion.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index cd3865e7a270..b4d635bb81ac 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -16,8 +16,6 @@
> #include <dt-bindings/clock/qcom,rpmcc.h>
>
> / {
> - model = "Qualcomm Technologies, Inc. MSM8996";
> -
> interrupt-parent = <&intc>;
>
> #address-cells = <2>;
> --
> 2.17.1
>
prev parent reply other threads:[~2018-09-06 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 18:35 [PATCH v2 0/3] arm msm compatible+model cleanup Niklas Cassel
2018-09-05 18:35 ` [PATCH v2 1/3] arm64: dts: db820c: Add qcom,apq8096 to compatible string Niklas Cassel
2018-09-05 18:35 ` [PATCH v2 2/3] arm64: dts: msm8916: Drop model and compatible Niklas Cassel
2018-09-06 15:55 ` Bjorn Andersson
2018-09-05 18:35 ` [PATCH v2 3/3] arm64: dts: msm8996: Drop model Niklas Cassel
2018-09-06 15:56 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906155614.GC3286@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).