[PATCH v2 0/3] arm msm compatible+model cleanup

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2 0/3] arm msm compatible+model cleanup
@ 2018-09-05 18:35 Niklas Cassel
  2018-09-05 18:35 ` [PATCH v2 1/3] arm64: dts: db820c: Add qcom,apq8096 to compatible string Niklas Cassel
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Niklas Cassel @ 2018-09-05 18:35 UTC (permalink / raw)
  To: Andy Gross, David Brown, Rob Herring, Mark Rutland
  Cc: Niklas Cassel, linux-arm-msm, linux-soc, devicetree, linux-kernel

Minor arm msm compatible+model cleanup


Changes since v1:
Instead of adding compatible to msm8996.dtsi,
drop both compatible and model from msm8996.dtsi
and msm8916.dtsi, since all DTS board files that
includes these already specifies both model and
compatible themselves.

Niklas Cassel (3):
  arm64: dts: db820c: Add qcom,apq8096 to compatible string
  arm64: dts: msm8916: Drop model and compatible
  arm64: dts: msm8996: Drop model

 arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +-
 arch/arm64/boot/dts/qcom/msm8916.dtsi       | 3 ---
 arch/arm64/boot/dts/qcom/msm8996.dtsi       | 2 --
 3 files changed, 1 insertion(+), 6 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/3] arm64: dts: db820c: Add qcom,apq8096 to compatible string
  2018-09-05 18:35 [PATCH v2 0/3] arm msm compatible+model cleanup Niklas Cassel
@ 2018-09-05 18:35 ` Niklas Cassel
  2018-09-05 18:35 ` [PATCH v2 2/3] arm64: dts: msm8916: Drop model and compatible Niklas Cassel
  2018-09-05 18:35 ` [PATCH v2 3/3] arm64: dts: msm8996: Drop model Niklas Cassel
  2 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel @ 2018-09-05 18:35 UTC (permalink / raw)
  To: Andy Gross, David Brown, Rob Herring, Mark Rutland
  Cc: Niklas Cassel, linux-arm-msm, linux-soc, devicetree, linux-kernel

Add qcom,apq8096 to compatible string.
This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt
and is needed for e.g. drivers/cpufreq/qcom-cpufreq-kryo.c to be probed
correctly (and for drivers/cpufreq/cpufreq-dt-platdev.c to work properly).

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index 230e9c8484ac..da23bdafbd33 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -17,5 +17,5 @@
 
 / {
 	model = "Qualcomm Technologies, Inc. DB820c";
-	compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc";
+	compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc", "qcom,apq8096";
 };
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/3] arm64: dts: msm8916: Drop model and compatible
  2018-09-05 18:35 [PATCH v2 0/3] arm msm compatible+model cleanup Niklas Cassel
  2018-09-05 18:35 ` [PATCH v2 1/3] arm64: dts: db820c: Add qcom,apq8096 to compatible string Niklas Cassel
@ 2018-09-05 18:35 ` Niklas Cassel
  2018-09-06 15:55   ` Bjorn Andersson
  2018-09-05 18:35 ` [PATCH v2 3/3] arm64: dts: msm8996: Drop model Niklas Cassel
  2 siblings, 1 reply; 6+ messages in thread
From: Niklas Cassel @ 2018-09-05 18:35 UTC (permalink / raw)
  To: Andy Gross, David Brown, Rob Herring, Mark Rutland
  Cc: Niklas Cassel, linux-arm-msm, linux-soc, devicetree, linux-kernel

DTS board files should always specify model and compatible.

All DTS board files that includes msm8916.dtsi
already specifies model and compatible, and will thus
override the model and compatible in msm8916.dtsi.

Drop model and compatible from msm8916.dtsi,
since they are only a source of confusion.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 7b32b8990d62..726a45960742 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -18,9 +18,6 @@
 #include <dt-bindings/thermal/thermal.h>
 
 / {
-	model = "Qualcomm Technologies, Inc. MSM8916";
-	compatible = "qcom,msm8916";
-
 	interrupt-parent = <&intc>;
 
 	#address-cells = <2>;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/3] arm64: dts: msm8916: Drop model and compatible
  2018-09-05 18:35 ` [PATCH v2 2/3] arm64: dts: msm8916: Drop model and compatible Niklas Cassel
@ 2018-09-06 15:55   ` Bjorn Andersson
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2018-09-06 15:55 UTC (permalink / raw)
  To: Niklas Cassel
  Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland, linux-arm-msm,
	linux-soc, devicetree, linux-kernel

On Wed 05 Sep 11:35 PDT 2018, Niklas Cassel wrote:

> DTS board files should always specify model and compatible.
> 
> All DTS board files that includes msm8916.dtsi
> already specifies model and compatible, and will thus
> override the model and compatible in msm8916.dtsi.
> 
> Drop model and compatible from msm8916.dtsi,
> since they are only a source of confusion.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 7b32b8990d62..726a45960742 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -18,9 +18,6 @@
>  #include <dt-bindings/thermal/thermal.h>
>  
>  / {
> -	model = "Qualcomm Technologies, Inc. MSM8916";
> -	compatible = "qcom,msm8916";
> -
>  	interrupt-parent = <&intc>;
>  
>  	#address-cells = <2>;
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 3/3] arm64: dts: msm8996: Drop model
  2018-09-05 18:35 [PATCH v2 0/3] arm msm compatible+model cleanup Niklas Cassel
  2018-09-05 18:35 ` [PATCH v2 1/3] arm64: dts: db820c: Add qcom,apq8096 to compatible string Niklas Cassel
  2018-09-05 18:35 ` [PATCH v2 2/3] arm64: dts: msm8916: Drop model and compatible Niklas Cassel
@ 2018-09-05 18:35 ` Niklas Cassel
  2018-09-06 15:56   ` Bjorn Andersson
  2 siblings, 1 reply; 6+ messages in thread
From: Niklas Cassel @ 2018-09-05 18:35 UTC (permalink / raw)
  To: Andy Gross, David Brown, Rob Herring, Mark Rutland
  Cc: Niklas Cassel, linux-arm-msm, linux-soc, devicetree, linux-kernel

DTS board files should always specify model and compatible.

All DTS board files that includes msm8996.dtsi
already specifies model and compatible, and will thus
override the model and compatible in msm8996.dtsi.

Drop model from msm8916.dtsi, since it is only a source of confusion.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index cd3865e7a270..b4d635bb81ac 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -16,8 +16,6 @@
 #include <dt-bindings/clock/qcom,rpmcc.h>
 
 / {
-	model = "Qualcomm Technologies, Inc. MSM8996";
-
 	interrupt-parent = <&intc>;
 
 	#address-cells = <2>;
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 3/3] arm64: dts: msm8996: Drop model
  2018-09-05 18:35 ` [PATCH v2 3/3] arm64: dts: msm8996: Drop model Niklas Cassel
@ 2018-09-06 15:56   ` Bjorn Andersson
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2018-09-06 15:56 UTC (permalink / raw)
  To: Niklas Cassel
  Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland, linux-arm-msm,
	linux-soc, devicetree, linux-kernel

On Wed 05 Sep 11:35 PDT 2018, Niklas Cassel wrote:

> DTS board files should always specify model and compatible.
> 
> All DTS board files that includes msm8996.dtsi
> already specifies model and compatible, and will thus
> override the model and compatible in msm8996.dtsi.
> 
> Drop model from msm8916.dtsi, since it is only a source of confusion.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index cd3865e7a270..b4d635bb81ac 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -16,8 +16,6 @@
>  #include <dt-bindings/clock/qcom,rpmcc.h>
>  
>  / {
> -	model = "Qualcomm Technologies, Inc. MSM8996";
> -
>  	interrupt-parent = <&intc>;
>  
>  	#address-cells = <2>;
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-06 15:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-05 18:35 [PATCH v2 0/3] arm msm compatible+model cleanup Niklas Cassel
2018-09-05 18:35 ` [PATCH v2 1/3] arm64: dts: db820c: Add qcom,apq8096 to compatible string Niklas Cassel
2018-09-05 18:35 ` [PATCH v2 2/3] arm64: dts: msm8916: Drop model and compatible Niklas Cassel
2018-09-06 15:55   ` Bjorn Andersson
2018-09-05 18:35 ` [PATCH v2 3/3] arm64: dts: msm8996: Drop model Niklas Cassel
2018-09-06 15:56   ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).