From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
devicetree@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Siddartha Mohanadoss <smohanad@codeaurora.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node
Date: Thu, 6 Sep 2018 13:36:15 -0700 [thread overview]
Message-ID: <20180906203615.GD22824@google.com> (raw)
In-Reply-To: <CAD=FV=Vvhjcs9UwLkyHJ+nxwRCk70SBC3eVxBXwK7DFcPeu8wQ@mail.gmail.com>
On Thu, Sep 06, 2018 at 11:34:32AM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Aug 27, 2018 at 10:10 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > On Fri, Aug 10, 2018 at 05:09:17PM -0700, Doug Anderson wrote:
> >> Hi,
> >>
> >> On Wed, Aug 8, 2018 at 12:13 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> >> > This adds the adc node to pm8998 based on the examples in the
> >> > bindings. It also fixes the order of the included headers.
> >> >
> >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> >> > ---
> >> > arch/arm64/boot/dts/qcom/pm8998.dtsi | 13 ++++++++++++-
> >> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> >> > index 92bed1e7d4bb..f70f6101bceb 100644
> >> > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> >> > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> >> > @@ -1,8 +1,9 @@
> >> > // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> >> > /* Copyright 2018 Google LLC. */
> >> >
> >> > -#include <dt-bindings/spmi/spmi.h>
> >> > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> >> > #include <dt-bindings/interrupt-controller/irq.h>
> >> > +#include <dt-bindings/spmi/spmi.h>
> >> >
> >> > &spmi_bus {
> >> > pm8998_lsid0: pmic@0 {
> >> > @@ -11,6 +12,16 @@
> >> > #address-cells = <1>;
> >> > #size-cells = <0>;
> >> >
> >> > + pm8998_adc: adc@3100 {
> >> > + compatible = "qcom,spmi-adc-rev2";
> >> > + reg = <0x3100>;
> >> > + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> >> > + #address-cells = <1>;
> >> > + #size-cells = <0>;
> >> > + #io-channel-cells = <1>;
> >> > + io-channel-ranges;
> >> > + };
> >>
> >> I'm a little confused about what the "io-channel-ranges" does here.
> >> The documentation isn't clear at all to me for it. If I'm reading it
> >> right it's also supposed to be for iio-consumers, but you're using it
> >> in a provider. I see you copied this from the example. Maybe the
> >> example is wrong? ...or I'm just confused...
> >
> > Yes, I copied it from the example, its use here is also not clear to
> > me, other ADC providers like adc@126c0000 in exynos3250.dtsi or
> > adc@180a6000 in bcm-cygnus.dtsi also specify it ...
> >
> > Siddartha/Jonathan, could you help to clarify if "io-channel-ranges"
> > should really be specified here as the DT example suggests?
>
> Does everything work if you just remove the "io-channel-ranges"?
Yes, the ADC channels are still available within the kernel and
through sysfs and provide reasonable values.
> We could remove it and always add it back in later if someone could
> explain what it's for or if we find a reason why it was needed? ...or
> we have any other ideas for how to get this resolved? :(
Sounds good, I'll respin with 'io-channel-ranges' removed.
next prev parent reply other threads:[~2018-09-06 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 19:13 [PATCH 0/3] arm64: dts: qcom: pm8998: Add ADC node and die temperature channel Matthias Kaehlcke
2018-08-08 19:13 ` [PATCH 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg' Matthias Kaehlcke
2018-08-08 20:28 ` Doug Anderson
2018-08-14 20:46 ` Rob Herring
2018-08-08 19:13 ` [PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node Matthias Kaehlcke
2018-08-11 0:09 ` Doug Anderson
2018-08-27 17:10 ` Matthias Kaehlcke
2018-09-06 18:34 ` Doug Anderson
2018-09-06 20:36 ` Matthias Kaehlcke [this message]
2018-08-08 19:13 ` [PATCH 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2018-08-11 0:10 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906203615.GD22824@google.com \
--to=mka@chromium.org \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=smohanad@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).