From: Tony Lindgren <tony@atomide.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: "Reizer, Eyal" <eyalr@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Gerlach, Dave" <d-gerlach@ti.com>,
"Strashko, Grygorii" <grygorii.strashko@ti.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Menon, Nishanth" <nm@ti.com>, "Kristo, Tero" <t-kristo@ti.com>
Subject: Re: [PATCH] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt
Date: Fri, 7 Sep 2018 10:35:36 -0700 [thread overview]
Message-ID: <20180907173536.GR5662@atomide.com> (raw)
In-Reply-To: <20171016140147.GV4394@atomide.com>
* Tony Lindgren <tony@atomide.com> [171016 14:03]:
> * Ladislav Michl <ladis@linux-mips.org> [171015 15:16]:
> > On Sun, Oct 15, 2017 at 09:22:31AM -0700, Tony Lindgren wrote:
> > > * Reizer, Eyal <eyalr@ti.com> [171014 23:55]:
> > > > > From: Tony Lindgren [mailto:tony@atomide.com]
> > > > >
> > > > > On omaps, if the wlcore interrupt is configured as level instead of edge,
> > > > > L4PER will stop doing hardware based idling after ifconfig wlan0 down is
> > > > > done and the WL_EN line is pulled down.
> > > > >
> > > > Do we understand why omap is doing this? Is it a bug or a normal behavior?
Just to document this, it looks like the gpio wake events
behave in a different way on omap4 and later. We must only
keep waken register configured during idle on omap4 and have
edge and level registers cleared to prevent the gpio from
keeping clocks on and blocking idle.
I'll be posting a proper fix for this at some point after
some more testing and cleaning up my patch.
Regards,
Tony
next prev parent reply other threads:[~2018-09-07 22:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 6:53 [PATCH] ARM: dts: Fix omap l4per idling with wlcore edge sensitive interrupt Reizer, Eyal
[not found] ` <8665E2433BC68541A24DFFCA87B70F5B3646AF81-1tpBd5JUCm6IQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2017-10-15 16:22 ` Tony Lindgren
[not found] ` <20171015162230.GU4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-15 22:15 ` Ladislav Michl
2017-10-16 14:01 ` Tony Lindgren
2018-09-07 17:35 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-13 19:32 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907173536.GR5662@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=eyalr@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=kvalo@codeaurora.org \
--cc=ladis@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).