From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property Date: Fri, 7 Sep 2018 23:43:15 +0200 Message-ID: <20180907214315.GA23873@ravnborg.org> References: <20180822183555.GA24084@ravnborg.org> <20180907193508.24974-2-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180907193508.24974-2-sam@ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org To: Alessandro Zummo , Alexandre Belloni , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Cc: =?iso-8859-1?Q?S=F8ren?= Andersen List-Id: devicetree@vger.kernel.org Hi all. > +Optional property: > +- nxp,quartz_load_12.5pF: The capacitive load on the quartz is 12.5 pF, > + which differ from the default value of 7 pF > + > +Example: > + > +pcf8523: pcf8523@68 { > + compatible = "nxp,pcf85063"; > + reg = <0x68>; > + nxp,quartz_load_12.5pF; > +}; The property described in the bindings uses capital F. But the intent was to use a lower-case f, so the property is all lower-case. Will fix in v2. This goes for both this binding file and the nxp,pcf85063.txt. The dts files and the implmentation uses lower-case f already. Sam