From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/5] dt-bindings: sun4i-drm: drop second PLL from A64 HDMI PHY binding Date: Mon, 10 Sep 2018 16:22:50 +0200 Message-ID: <20180910142250.he54s4pm436qyshs@flea> References: <20180907072234.48282-1-icenowy@aosc.io> <20180907072234.48282-2-icenowy@aosc.io> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ats4uxpwvt5bttal" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20180907072234.48282-2-icenowy-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Chen-Yu Tsai , Rob Herring , Jernej Skrabec , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --ats4uxpwvt5bttal Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Fri, Sep 07, 2018 at 03:22:30PM +0800, Icenowy Zheng wrote: > By experiments it seems that the A64 HDMI PHY is not able to use the > second video PLL as the clock parent. > > Drop pll-1 from the device tree binding of A64 HDMI PHY. > > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index f8773ecb7525..62034039cee1 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -114,7 +114,6 @@ Required properties: > > H3 and A64 HDMI PHY require additional clocks: > - pll-0: parent of phy clock > - - pll-1: second possible phy clock parent (A64 only) You shouldn't need to do this. The DT is about the hardware. The fact that we haven't figured out how to use it is quite irrelevant, and can change in the future, unlike this binding. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ats4uxpwvt5bttal--