From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 10/13] ASoC: dt-bindings: Add WCD9335 MBHC specific properties Date: Mon, 10 Sep 2018 15:06:53 -0500 Message-ID: <20180910200652.GA20896@bogus> References: <20180904102500.30318-1-srinivas.kandagatla@linaro.org> <20180904102500.30318-11-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180904102500.30318-11-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Srinivas Kandagatla Cc: lee.jones@linaro.org, broonie@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, bgoswami@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, alsa-devel@alsa-project.org List-Id: devicetree@vger.kernel.org On Tue, Sep 04, 2018 at 11:24:57AM +0100, Srinivas Kandagatla wrote: > This patch add new bindings required to support MBHC > (Multi Button Headset Control) block in the codec. > This block is used for jack insert/removal detection, > headset type detection and 8 button press/release events. > > All these properties are very much specific to board. > > Signed-off-by: Srinivas Kandagatla > --- > .../bindings/sound/qcom,wcd9335.txt | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > index 5d6ea66a863f..4d56c3ca9fa8 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > @@ -55,6 +55,26 @@ Required properties with SLIMbus Interface: > Value type: > Definition: Must contain "mclk", "mclk2" and "slimbus" strings. > > +- qcom,mbhc-vthreshold: Needs unit suffix. > + Usage: Optional, only required if headset button support required. > + Value type: > + Definition: Must contain an array of 8 threshold voltages in mV for > + 8 buttons detection on headset. > + > +- qcom,hphl-jack-type-normally-open: > + Usage: Optional, only required if headset button support required. It's not required if the pin is NC, right? > + Value type: > + Definition: present if hphl pin on jack is a NO (Normally Open). > + If not specified, then its assumed that hphl pin on jack > + is NC (Normally Closed). Is the not specified case the more common case? If not, it should be. > + > +- qcom,gnd-jack-type-normally-open: > + Usage: Optional, only required if headset button support required. Same here. > + Value type: > + Definition: present if gnd pin on jack is NO (Normally Open). > + If not specified, then its assumed that gnd pin on > + jack is NC (Normally Closed). > + > - vdd-buck-supply: > Usage: required > Value type: > -- > 2.18.0 >