From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP Date: Wed, 12 Sep 2018 08:23:35 +0200 Message-ID: <20180912062335.GB7949@pengutronix.de> References: <20180910125056.30813-1-s.hauer@pengutronix.de> <20180912012252.GE28469@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180912012252.GE28469@dragon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Shawn Guo Cc: Fabio Estevam , devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, NXP Linux Team List-Id: devicetree@vger.kernel.org Hi Shawn, On Wed, Sep 12, 2018 at 09:22:54AM +0800, Shawn Guo wrote: > On Mon, Sep 10, 2018 at 02:50:56PM +0200, Sascha Hauer wrote: > > The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the > > 1.2GHz OPP. This makes the board work with cpufreq again. > > I feel that the word 'again' and the Fixes tag below are a little > confusing. It makes impression that cpufreq worked fine on the board > before and commit 791f416608 broke it. However, this is not the case, > right? You're right, the "again" shouldn't be there. I meant that the board works "again" after the addition of cpufreq support broke it. Just resent the patch with a rephrased commit message. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |