From: Shawn Guo <shawnguo@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP
Date: Wed, 12 Sep 2018 14:46:52 +0800 [thread overview]
Message-ID: <20180912064649.GC28239@dragon> (raw)
In-Reply-To: <20180912062335.GB7949@pengutronix.de>
On Wed, Sep 12, 2018 at 08:23:35AM +0200, Sascha Hauer wrote:
> Hi Shawn,
>
> On Wed, Sep 12, 2018 at 09:22:54AM +0800, Shawn Guo wrote:
> > On Mon, Sep 10, 2018 at 02:50:56PM +0200, Sascha Hauer wrote:
> > > The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the
> > > 1.2GHz OPP. This makes the board work with cpufreq again.
> >
> > I feel that the word 'again' and the Fixes tag below are a little
> > confusing. It makes impression that cpufreq worked fine on the board
> > before and commit 791f416608 broke it. However, this is not the case,
> > right?
>
> You're right, the "again" shouldn't be there. I meant that the board
> works "again" after the addition of cpufreq support broke it.
>
> Just resent the patch with a rephrased commit message.
Thanks, Sascha.
Shawn
next prev parent reply other threads:[~2018-09-12 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 12:50 [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP Sascha Hauer
2018-09-12 1:22 ` Shawn Guo
2018-09-12 6:23 ` Sascha Hauer
2018-09-12 6:46 ` Shawn Guo [this message]
2018-09-12 6:23 ` [PATCH v2] " Sascha Hauer
2018-09-12 6:45 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912064649.GC28239@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).