* [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP
@ 2018-09-10 12:50 Sascha Hauer
2018-09-12 1:22 ` Shawn Guo
2018-09-12 6:23 ` [PATCH v2] " Sascha Hauer
0 siblings, 2 replies; 6+ messages in thread
From: Sascha Hauer @ 2018-09-10 12:50 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Sascha Hauer, NXP Linux Team, kernel, Fabio Estevam,
Shawn Guo
The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the
1.2GHz OPP. This makes the board work with cpufreq again.
Fixes: 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boot/dts/imx53-qsb-common.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/imx53-qsb-common.dtsi b/arch/arm/boot/dts/imx53-qsb-common.dtsi
index 7423d462d1e4..50dde84b72ed 100644
--- a/arch/arm/boot/dts/imx53-qsb-common.dtsi
+++ b/arch/arm/boot/dts/imx53-qsb-common.dtsi
@@ -123,6 +123,17 @@
};
};
+&cpu0 {
+ /* CPU rated to 1GHz, not 1.2GHz as per the default settings */
+ operating-points = <
+ /* kHz uV */
+ 166666 850000
+ 400000 900000
+ 800000 1050000
+ 1000000 1200000
+ >;
+};
+
&esdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_esdhc1>;
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP
2018-09-10 12:50 [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP Sascha Hauer
@ 2018-09-12 1:22 ` Shawn Guo
2018-09-12 6:23 ` Sascha Hauer
2018-09-12 6:23 ` [PATCH v2] " Sascha Hauer
1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-09-12 1:22 UTC (permalink / raw)
To: Sascha Hauer
Cc: Fabio Estevam, devicetree, kernel, linux-arm-kernel,
NXP Linux Team
On Mon, Sep 10, 2018 at 02:50:56PM +0200, Sascha Hauer wrote:
> The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the
> 1.2GHz OPP. This makes the board work with cpufreq again.
I feel that the word 'again' and the Fixes tag below are a little
confusing. It makes impression that cpufreq worked fine on the board
before and commit 791f416608 broke it. However, this is not the case,
right?
>
> Fixes: 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")
Shawn
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/boot/dts/imx53-qsb-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx53-qsb-common.dtsi b/arch/arm/boot/dts/imx53-qsb-common.dtsi
> index 7423d462d1e4..50dde84b72ed 100644
> --- a/arch/arm/boot/dts/imx53-qsb-common.dtsi
> +++ b/arch/arm/boot/dts/imx53-qsb-common.dtsi
> @@ -123,6 +123,17 @@
> };
> };
>
> +&cpu0 {
> + /* CPU rated to 1GHz, not 1.2GHz as per the default settings */
> + operating-points = <
> + /* kHz uV */
> + 166666 850000
> + 400000 900000
> + 800000 1050000
> + 1000000 1200000
> + >;
> +};
> +
> &esdhc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_esdhc1>;
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP
2018-09-12 1:22 ` Shawn Guo
@ 2018-09-12 6:23 ` Sascha Hauer
2018-09-12 6:46 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2018-09-12 6:23 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, devicetree, kernel, linux-arm-kernel,
NXP Linux Team
Hi Shawn,
On Wed, Sep 12, 2018 at 09:22:54AM +0800, Shawn Guo wrote:
> On Mon, Sep 10, 2018 at 02:50:56PM +0200, Sascha Hauer wrote:
> > The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the
> > 1.2GHz OPP. This makes the board work with cpufreq again.
>
> I feel that the word 'again' and the Fixes tag below are a little
> confusing. It makes impression that cpufreq worked fine on the board
> before and commit 791f416608 broke it. However, this is not the case,
> right?
You're right, the "again" shouldn't be there. I meant that the board
works "again" after the addition of cpufreq support broke it.
Just resent the patch with a rephrased commit message.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP
2018-09-12 6:23 ` Sascha Hauer
@ 2018-09-12 6:46 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-09-12 6:46 UTC (permalink / raw)
To: Sascha Hauer
Cc: Fabio Estevam, devicetree, kernel, linux-arm-kernel,
NXP Linux Team
On Wed, Sep 12, 2018 at 08:23:35AM +0200, Sascha Hauer wrote:
> Hi Shawn,
>
> On Wed, Sep 12, 2018 at 09:22:54AM +0800, Shawn Guo wrote:
> > On Mon, Sep 10, 2018 at 02:50:56PM +0200, Sascha Hauer wrote:
> > > The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the
> > > 1.2GHz OPP. This makes the board work with cpufreq again.
> >
> > I feel that the word 'again' and the Fixes tag below are a little
> > confusing. It makes impression that cpufreq worked fine on the board
> > before and commit 791f416608 broke it. However, this is not the case,
> > right?
>
> You're right, the "again" shouldn't be there. I meant that the board
> works "again" after the addition of cpufreq support broke it.
>
> Just resent the patch with a rephrased commit message.
Thanks, Sascha.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: dts: imx53-qsb: disable 1.2GHz OPP
2018-09-10 12:50 [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP Sascha Hauer
2018-09-12 1:22 ` Shawn Guo
@ 2018-09-12 6:23 ` Sascha Hauer
2018-09-12 6:45 ` Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2018-09-12 6:23 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, Sascha Hauer, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the
1.2GHz OPP. This makes the board work again with configs that have
cpufreq enabled like imx_v6_v7_defconfig on which the board stopped
working with the addition of cpufreq-dt support.
Fixes: 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Changes since v1:
- rephrase commit message
arch/arm/boot/dts/imx53-qsb-common.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/imx53-qsb-common.dtsi b/arch/arm/boot/dts/imx53-qsb-common.dtsi
index 7423d462d1e4..50dde84b72ed 100644
--- a/arch/arm/boot/dts/imx53-qsb-common.dtsi
+++ b/arch/arm/boot/dts/imx53-qsb-common.dtsi
@@ -123,6 +123,17 @@
};
};
+&cpu0 {
+ /* CPU rated to 1GHz, not 1.2GHz as per the default settings */
+ operating-points = <
+ /* kHz uV */
+ 166666 850000
+ 400000 900000
+ 800000 1050000
+ 1000000 1200000
+ >;
+};
+
&esdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_esdhc1>;
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] ARM: dts: imx53-qsb: disable 1.2GHz OPP
2018-09-12 6:23 ` [PATCH v2] " Sascha Hauer
@ 2018-09-12 6:45 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-09-12 6:45 UTC (permalink / raw)
To: Sascha Hauer
Cc: Fabio Estevam, devicetree, kernel, linux-arm-kernel,
NXP Linux Team
On Wed, Sep 12, 2018 at 08:23:01AM +0200, Sascha Hauer wrote:
> The maximum CPU frequency for the i.MX53 QSB is 1GHz, so disable the
> 1.2GHz OPP. This makes the board work again with configs that have
> cpufreq enabled like imx_v6_v7_defconfig on which the board stopped
> working with the addition of cpufreq-dt support.
>
> Fixes: 791f416608 ("ARM: dts: imx53: add cpufreq-dt support")
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-12 6:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-10 12:50 [PATCH] ARM: dts: imx53-qsb: disable 1.2GHz OPP Sascha Hauer
2018-09-12 1:22 ` Shawn Guo
2018-09-12 6:23 ` Sascha Hauer
2018-09-12 6:46 ` Shawn Guo
2018-09-12 6:23 ` [PATCH v2] " Sascha Hauer
2018-09-12 6:45 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).