* [PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl
@ 2018-09-07 8:18 Ludovic Desroches
2018-09-07 8:56 ` Nicolas Ferre
2018-09-12 10:38 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Ludovic Desroches @ 2018-09-07 8:18 UTC (permalink / raw)
To: linux-arm-kernel, devicetree
Cc: nicolas.ferre, alexandre.belloni, robh+dt, mark.rutland,
linux-kernel, Ludovic Desroches
The drive strength has to be set to medium otherwise some data
corruption may happen.
Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
Hi,
This fix depends on the support of the drive-strength for the atmel pio4
pinctroller. It has been added in v4.19 but I omitted to send it at the
same time.
Ludovic
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
index b10dccd0958f..3b1baa8605a7 100644
--- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
@@ -11,6 +11,7 @@
#include "sama5d2-pinfunc.h"
#include <dt-bindings/mfd/atmel-flexcom.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pinctrl/at91.h>
/ {
model = "Atmel SAMA5D2 PTC EK";
@@ -299,6 +300,7 @@
<PIN_PA30__NWE_NANDWE>,
<PIN_PB2__NRD_NANDOE>;
bias-pull-up;
+ atmel,drive-strength = <ATMEL_PIO_DRVSTR_ME>;
};
ale_cle_rdy_cs {
--
2.12.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl
2018-09-07 8:18 [PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl Ludovic Desroches
@ 2018-09-07 8:56 ` Nicolas Ferre
2018-09-12 10:38 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2018-09-07 8:56 UTC (permalink / raw)
To: Ludovic Desroches, linux-arm-kernel, devicetree
Cc: alexandre.belloni, robh+dt, mark.rutland, linux-kernel
On 07/09/2018 at 10:18, Ludovic Desroches wrote:
> The drive strength has to be set to medium otherwise some data
> corruption may happen.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
>
> Hi,
>
> This fix depends on the support of the drive-strength for the atmel pio4
> pinctroller. It has been added in v4.19 but I omitted to send it at the
> same time.
Could be good to be queued for "4.19-fixes".
Best regards,
Nicolas
> Ludovic
>
> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> index b10dccd0958f..3b1baa8605a7 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> @@ -11,6 +11,7 @@
> #include "sama5d2-pinfunc.h"
> #include <dt-bindings/mfd/atmel-flexcom.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/at91.h>
>
> / {
> model = "Atmel SAMA5D2 PTC EK";
> @@ -299,6 +300,7 @@
> <PIN_PA30__NWE_NANDWE>,
> <PIN_PB2__NRD_NANDOE>;
> bias-pull-up;
> + atmel,drive-strength = <ATMEL_PIO_DRVSTR_ME>;
> };
>
> ale_cle_rdy_cs {
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl
2018-09-07 8:18 [PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl Ludovic Desroches
2018-09-07 8:56 ` Nicolas Ferre
@ 2018-09-12 10:38 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2018-09-12 10:38 UTC (permalink / raw)
To: Ludovic Desroches
Cc: linux-arm-kernel, devicetree, nicolas.ferre, robh+dt,
mark.rutland, linux-kernel
On 07/09/2018 10:18:51+0200, Ludovic Desroches wrote:
> The drive strength has to be set to medium otherwise some data
> corruption may happen.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
>
> Hi,
>
> This fix depends on the support of the drive-strength for the atmel pio4
> pinctroller. It has been added in v4.19 but I omitted to send it at the
> same time.
>
> Ludovic
>
> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-12 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-07 8:18 [PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl Ludovic Desroches
2018-09-07 8:56 ` Nicolas Ferre
2018-09-12 10:38 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).