From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 14 Sep 2018 06:37:41 -0300 From: Mauro Carvalho Chehab Subject: Re: [PATCH v2 0/7] TVP5150 fixes and new features Message-ID: <20180914063741.407b517b@coco.lan> In-Reply-To: <20180914084303.pvqm35cbe6vznoci@pengutronix.de> References: <20180813092508.1334-1-m.felsch@pengutronix.de> <20180914084303.pvqm35cbe6vznoci@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Marco Felsch Cc: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kernel@pengutronix.de, devicetree@vger.kernel.org, p.zabel@pengutronix.de, javierm@redhat.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, afshin.nasser@gmail.com, linux-media@vger.kernel.org List-ID: Em Fri, 14 Sep 2018 10:43:03 +0200 Marco Felsch escreveu: > Hi, > > since I sent this series I only got feedback from Rob. I'm doing some tests on it. If everything gets ok, I'll likely merge it today. > > Regards, > Marco > > On 18-08-13 11:25, Marco Felsch wrote: > > Hi, > > > > this is my v2 with the integrated reviews from my v1 [1]. Since Mauro > > applied the most patches from my v1 to his experimental/tvp5150-3 > > branch [2], this series only contains those which aren't applied. > > > > Patches I changed contain a changelog, so I will omit these here. > > > > Patch ('[media] tvp5150: add FORMAT_TRY support for get/set selection > > handlers') throws a compile error. Therefore I added two v4l2-subdev.h > > patches which should fix the error in a common way. > > > > Patch ('[media] tvp5150: add s_power callback') is new too. I forget > > them in my v1. This patch address the interrupt enable/disable handling. > > Now it is possible to pause streaming and keep the interrupts on. > > > > The changes I made in the ('[media] tvp5150: add input source selection > > of_graph support') patch are based on the the RFC [3] and discussion [4]. > > I dropped patch ('[media] tvp5150: Change default input source selection > > behaviour') since the default input source selectopn is setup during the > > .registered() callback now. > > > > I've tested this series on a customer dt-based board. Unfortunately I > > haven't a device which use the em28xx driver. So other tester a welcome :) > > > > [1] https://www.spinics.net/lists/devicetree/msg236650.html > > [2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-3 > > [3] https://www.spinics.net/lists/devicetree/msg243181.html > > [4] https://www.spinics.net/lists/devicetree/msg243840.html > > > > Regards, > > Marco > > > > Marco Felsch (6): > > [media] tvp5150: add input source selection of_graph support > > [media] dt-bindings: tvp5150: Add input port connectors DT bindings > > [media] v4l2-subdev: add stubs for v4l2_subdev_get_try_* > > [media] v4l2-subdev: fix v4l2_subdev_get_try_* dependency > > [media] tvp5150: add FORMAT_TRY support for get/set selection handlers > > [media] tvp5150: add s_power callback > > > > Michael Tretter (1): > > [media] tvp5150: initialize subdev before parsing device tree > > > > .../devicetree/bindings/media/i2c/tvp5150.txt | 191 +++++- > > drivers/media/i2c/tvp5150.c | 611 +++++++++++++++--- > > include/media/v4l2-subdev.h | 111 ++-- > > 3 files changed, 776 insertions(+), 137 deletions(-) > > > > -- > > 2.18.0 > > > > Thanks, Mauro