From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 5/7] MIPS: mscc: ocelot: add GPIO4 pinmuxing DT node Date: Fri, 14 Sep 2018 16:54:46 +0200 Message-ID: <20180914145446.GQ14988@piout.net> References: <92e37a04e77003f01a67ac5e49e66ae83f87c591.1536916714.git-series.quentin.schulz@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <92e37a04e77003f01a67ac5e49e66ae83f87c591.1536916714.git-series.quentin.schulz@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Quentin Schulz Cc: ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, allan.nielsen@microchip.com, linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, antoine.tenart@bootlin.com List-Id: devicetree@vger.kernel.org Hi, On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > declare a new pinctrl DT node for it. > > Signed-off-by: Quentin Schulz > --- > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > index 8ce317c..b5c4c74 100644 > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > @@ -182,6 +182,11 @@ > interrupts = <13>; > #interrupt-cells = <2>; > > + gpio4: gpio4 { > + pins = "GPIO_4"; > + function = "gpio"; > + }; > + For a GPIO, I would do that in the board dts because it is not used directly in the dtsi. > uart_pins: uart-pins { > pins = "GPIO_6", "GPIO_7"; > function = "uart"; > -- > git-series 0.9.1 -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com