From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention Date: Tue, 18 Sep 2018 09:53:11 +0200 Message-ID: <20180918075311.GB22202@nazgul.tnic> References: <1537194305-9243-1-git-send-email-manish.narani@xilinx.com> <1537194305-9243-2-git-send-email-manish.narani@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1537194305-9243-2-git-send-email-manish.narani@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Manish Narani Cc: robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org, michal.simek@xilinx.com, leoyang.li@nxp.com, sudeep.holla@arm.com, amit.kucheria@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Mon, Sep 17, 2018 at 07:54:59PM +0530, Manish Narani wrote: > Update the comments in the Synopsys EDAC driver. Minor changes to function > names and return types are also included. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 176 ++++++++++++++++++++----------------------- > 1 file changed, 80 insertions(+), 96 deletions(-) So this patch does a bunch of things together and should be split into: * functional changes like code cleanup * functions renaming * comments cleanup Maybe in that order. This way you'll have one logical set of changes per patch and review will be almost trivial. Thx. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --