From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Duszynski Subject: Re: [PATCH 2/2] iio: light: bh1750: Add device tree support Date: Wed, 19 Sep 2018 21:22:39 +0200 Message-ID: <20180919192238.GA19391@arch> References: <387c145949692c0318f90d98426be95c82ea2e58.1537033044.git.decatf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <387c145949692c0318f90d98426be95c82ea2e58.1537033044.git.decatf@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: ryang Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Comments inline. On Sat, Sep 15, 2018 at 01:42:14PM -0400, ryang wrote: > Add device tree support for ROHM BH1750 series ambient light sensors. > > Signed-off-by: ryang > --- > drivers/iio/light/bh1750.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c > index a814828e69f5..50b599abb383 100644 > --- a/drivers/iio/light/bh1750.c > +++ b/drivers/iio/light/bh1750.c > @@ -315,9 +315,19 @@ static const struct i2c_device_id bh1750_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, bh1750_id); > > +static const struct of_device_id bh1750_of_match[] = { > + { .compatible = "rohm,bh1710", }, > + { .compatible = "rohm,bh1715", }, > + { .compatible = "rohm,bh1721", }, > + { .compatible = "rohm,bh1750", }, > + { .compatible = "rohm,bh1751", }, > + { } > +}; > + Hmm, I believe this should be exported additionally using MODULE_DEVICE_TABLE(of, bh1750_of_match). Otherwise module loading will not work as expected. Moreover, we can do without DT and if you want to avoid warning about unused variables you may consider enclosing everything with: #ifdef CONFIG_OF ... #endif > static struct i2c_driver bh1750_driver = { > .driver = { > .name = "bh1750", > + .of_match_table = of_match_ptr(bh1750_of_match), > .pm = BH1750_PM_OPS, I've recently simplified setting pm ops so this would not apply to iio/togreg cleanly. > }, > .probe = bh1750_probe, > -- > 2.17.1 >