From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller Date: Fri, 21 Sep 2018 11:15:32 +0200 Message-ID: <20180921091532.GC30439@nazgul.tnic> References: <1537194305-9243-1-git-send-email-manish.narani@xilinx.com> <1537194305-9243-3-git-send-email-manish.narani@xilinx.com> <20180918075522.GC22202@nazgul.tnic> <20180919111553.GA9140@nazgul.tnic> <20180921090721.GB30439@nazgul.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20180921090721.GB30439@nazgul.tnic> Sender: linux-kernel-owner@vger.kernel.org To: Manish Narani Cc: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab@kernel.org" , Michal Simek , "leoyang.li@nxp.com" , "sudeep.holla@arm.com" , "amit.kucheria@linaro.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org There's more: I said: > > @@ -370,12 +398,12 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) > That function returns 0 unconditionally. Make it a void in a prepatch. But you've lumped this change together with a bunch more. Maybe my request wasn't clear so let me rephrase it: That function returns 0 unconditionally. Make it a void in a *separate* prepatch. Ok? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --