From: Guo Ren <ren_guo@c-sky.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com,
arnd@arndb.de, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, c-sky_gcc_upstream@c-sky.com,
green.hu@gmail.com
Subject: Re: [PATCH V8 1/2] clocksource: add gx6605s SOC system timer
Date: Fri, 21 Sep 2018 19:24:43 +0800 [thread overview]
Message-ID: <20180921112443.GA17701@guoren> (raw)
In-Reply-To: <271900ce-0019-b96d-7833-4ea5ae0721a6@linaro.org>
On Fri, Sep 21, 2018 at 01:57:27AM +0200, Daniel Lezcano wrote:
> On 21/09/2018 01:31, Guo Ren wrote:
> > On Thu, Sep 20, 2018 at 06:06:19PM +0200, Daniel Lezcano wrote:
> >> On 20/09/2018 10:03, Guo Ren wrote:
> >>> Changelog:
> >>> - Add License and Copyright
> >>> - Use timer-of framework
> >>> - Change name with upstream feedback
> >>> - Use clksource_mmio framework
> >>>
> >>> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> >>> ---
> >>> drivers/clocksource/Kconfig | 8 ++
> >>> drivers/clocksource/Makefile | 1 +
> >>> drivers/clocksource/timer-gx6605s.c | 150 ++++++++++++++++++++++++++++++++++++
> >>> 3 files changed, 159 insertions(+)
> >>> create mode 100644 drivers/clocksource/timer-gx6605s.c
> >>>
> >>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> >>> index a11f4ba..6d0f18d 100644
> >>> --- a/drivers/clocksource/Kconfig
> >>> +++ b/drivers/clocksource/Kconfig
> >>> @@ -620,4 +620,12 @@ config RISCV_TIMER
> >>> is accessed via both the SBI and the rdcycle instruction. This is
> >>> required for all RISC-V systems.
> >>>
> >>> +config GX6605S_TIMER
> >>> + bool "Gx6605s SOC system timer driver"
> >>> + depends on CSKY
> >>> + select CLKSRC_MMIO
> >>> + select TIMER_OF
> >>> + help
> >>> + This option enables support for gx6605s SOC's timer.
> >>> +
> >>> endmenu
> >>
> >> Please make the option not visible as default. There are currently two
> >> approaches look at MTK_TIMER and SPRD_TIMER.
> > Em ... (ot sure why COMPILE_TEST?):
> > bool "Gx6605s SOC system timer driver" if COMPILE_TEST
> > Hmm?
>
> Because by enabling the COMPILE_TEST, you give the opportunity to
> someone without the hardware to cross-compile test your driver and catch
> errors very soon before the changes hit your tree.
>
> There are several Continuous Integration loop around running the latest
> changes in the kernel (kernelci, 01.org, etc ...) and all drivers with
> this flag are compiled tested.
>
> If the option is not set, the timer is silently selected by your
> platform's Kconfig only, without giving the opportunity to an non-expert
> user to unselect the timer leading to, maybe, an unbootable board.
>
I got it, thx for the reply.
Best Regards
Guo Ren
next prev parent reply other threads:[~2018-09-21 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 8:03 [PATCH V8 0/2] clocksource: add gx6605s SOC system timer Guo Ren
2018-09-20 8:03 ` [PATCH V8 1/2] " Guo Ren
2018-09-20 16:06 ` Daniel Lezcano
2018-09-20 23:31 ` Guo Ren
2018-09-20 23:57 ` Daniel Lezcano
2018-09-21 11:24 ` Guo Ren [this message]
2018-09-20 8:03 ` [PATCH V8 2/2] dt-bindings: timer: gx6605s SOC timer Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921112443.GA17701@guoren \
--to=ren_guo@c-sky.com \
--cc=arnd@arndb.de \
--cc=c-sky_gcc_upstream@c-sky.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=green.hu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).