From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Rodrigo Exterckötter Tjäder" <rodrigo@tjader.xyz>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet
Date: Fri, 21 Sep 2018 16:29:41 +0200 [thread overview]
Message-ID: <20180921142941.5ymp7ksphgboxrwz@flea> (raw)
In-Reply-To: <20180919141938.18791-1-rodrigo@tjader.xyz>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote:
> Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
> but not send.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
Again, that commit log would be nice if it was a bit more
explicit. What is a DTP? How did you come up with that value? What is
the value used by Allwinner/Olimex, and why did you use another one if
you did?
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-21 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:19 [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet Rodrigo Exterckötter Tjäder
2018-09-21 14:29 ` Maxime Ripard [this message]
2018-09-21 15:25 ` Rodrigo Exterckötter Tjäder
2018-09-26 9:45 ` Maxime Ripard
2018-09-26 15:14 ` Rodrigo Exterckötter Tjäder
2018-09-26 17:05 ` Maxime Ripard
2018-09-26 19:48 ` [PATCH v2] arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay Rodrigo Exterckötter Tjäder
2018-09-27 10:51 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921142941.5ymp7ksphgboxrwz@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rodrigo@tjader.xyz \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).