From: Wolfram Sang <wsa@the-dreams.de>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>
Subject: Re: [PATCH 2/4] pinctrl: sh-pfc: r8a77470: Add SDHI2 voltage switch
Date: Sat, 22 Sep 2018 20:44:43 +0200 [thread overview]
Message-ID: <20180922184443.GD841@kunai> (raw)
In-Reply-To: <1537530911-443-3-git-send-email-fabrizio.castro@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Fri, Sep 21, 2018 at 12:55:09PM +0100, Fabrizio Castro wrote:
> Add SH_PFC_PIN_CFG_IO_VOLTAGE definition for the SDHI2 pins
> capable of switching voltage. Please note that with the
> RZ/G1C only 1 bit of the POC Control Register is used to
> control each interface.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
In general:
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> + if (_bank == 4 && _pin >= 14 && _pin <= 19)
> + return 1;
> +
> + return -EINVAL;
I'd like a tad better to bail out on the error case and have the main
path returning on the good case, but no strong opinion...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-22 18:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 11:55 [PATCH 0/4] Add SDHI2 support to iwg23s Fabrizio Castro
2018-09-21 11:55 ` [PATCH 1/4] dt-bindings: mmc: renesas_sdhi: Add r8a77470 support Fabrizio Castro
2018-09-22 18:43 ` Wolfram Sang
2018-09-24 9:11 ` Simon Horman
2018-09-24 9:37 ` Geert Uytterhoeven
2018-09-24 12:26 ` Wolfram Sang
2018-09-24 12:44 ` Geert Uytterhoeven
2018-09-24 18:33 ` Fabrizio Castro
2018-09-25 6:47 ` Geert Uytterhoeven
2018-09-25 7:47 ` Simon Horman
2018-09-25 7:55 ` Geert Uytterhoeven
2018-09-25 8:22 ` Wolfram Sang
2018-09-25 8:28 ` Geert Uytterhoeven
2018-09-25 12:45 ` Fabrizio Castro
2018-09-25 13:03 ` Geert Uytterhoeven
2018-09-25 13:12 ` Fabrizio Castro
2018-09-26 18:08 ` Fabrizio Castro
2018-09-21 11:55 ` [PATCH 2/4] pinctrl: sh-pfc: r8a77470: Add SDHI2 voltage switch Fabrizio Castro
2018-09-22 18:44 ` Wolfram Sang [this message]
2018-09-24 9:51 ` Geert Uytterhoeven
2018-09-24 18:36 ` Fabrizio Castro
2018-09-21 11:55 ` [PATCH 3/4] ARM: dts: r8a77470: Add SDHI2 support Fabrizio Castro
2018-09-22 18:44 ` Wolfram Sang
2018-09-24 9:12 ` Simon Horman
2018-09-28 9:31 ` Fabrizio Castro
2018-10-01 13:13 ` Simon Horman
2018-10-01 13:41 ` Fabrizio Castro
2018-09-24 9:16 ` Simon Horman
2018-09-21 11:55 ` [PATCH 4/4] ARM: dts: iwg23s-sbc: Add uSD card support Fabrizio Castro
2018-09-22 18:44 ` Wolfram Sang
2018-09-24 9:13 ` Simon Horman
2018-09-24 9:30 ` Fabrizio Castro
2018-09-24 10:03 ` Geert Uytterhoeven
2018-09-24 15:09 ` Fabrizio Castro
2018-09-24 15:34 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180922184443.GD841@kunai \
--to=wsa@the-dreams.de \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).