* [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation
@ 2018-09-22 21:05 ryang
2018-09-22 21:05 ` [PATCH v3 2/2] iio: light: bh1750: Add device tree support ryang
2018-09-27 19:31 ` [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: ryang @ 2018-09-22 21:05 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Rob Herring, Mark Rutland, linux-iio, devicetree, linux-kernel,
ryang
Document device tree bindings for ROHM BH1750 ambient light sensor driver.
Signed-off-by: ryang <decatf@gmail.com>
---
.../devicetree/bindings/iio/light/bh1750.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.txt b/Documentation/devicetree/bindings/iio/light/bh1750.txt
new file mode 100644
index 000000000000..468350cc7af6
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/bh1750.txt
@@ -0,0 +1,18 @@
+ROHM BH1750 - ALS, Ambient light sensor
+
+Required properties:
+
+- compatible: Must be one of:
+ "rohm,bh1710"
+ "rohm,bh1715"
+ "rohm,bh1721"
+ "rohm,bh1750"
+ "rohm,bh1751"
+- reg: the I2C address of the sensor
+
+Example:
+
+bh1750@23 {
+ compatible = "rohm,bh1750";
+ reg = <0x23>;
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v3 2/2] iio: light: bh1750: Add device tree support
2018-09-22 21:05 [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation ryang
@ 2018-09-22 21:05 ` ryang
2018-09-27 19:31 ` [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: ryang @ 2018-09-22 21:05 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Rob Herring, Mark Rutland, linux-iio, devicetree, linux-kernel,
ryang
Add device tree support for ROHM BH1750 series ambient light sensors.
Signed-off-by: ryang <decatf@gmail.com>
---
Changes in v2:
- Export module device table
Changes in v3:
- Remove of_match_ptr so that bh1750_of_match is available
without CONFIG_OF.
drivers/iio/light/bh1750.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c
index c3a481452b67..28347df78cff 100644
--- a/drivers/iio/light/bh1750.c
+++ b/drivers/iio/light/bh1750.c
@@ -307,9 +307,20 @@ static const struct i2c_device_id bh1750_id[] = {
};
MODULE_DEVICE_TABLE(i2c, bh1750_id);
+static const struct of_device_id bh1750_of_match[] = {
+ { .compatible = "rohm,bh1710", },
+ { .compatible = "rohm,bh1715", },
+ { .compatible = "rohm,bh1721", },
+ { .compatible = "rohm,bh1750", },
+ { .compatible = "rohm,bh1751", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, bh1750_of_match);
+
static struct i2c_driver bh1750_driver = {
.driver = {
.name = "bh1750",
+ .of_match_table = bh1750_of_match,
.pm = &bh1750_pm_ops,
},
.probe = bh1750_probe,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation
2018-09-22 21:05 [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation ryang
2018-09-22 21:05 ` [PATCH v3 2/2] iio: light: bh1750: Add device tree support ryang
@ 2018-09-27 19:31 ` Rob Herring
2018-09-29 11:26 ` Jonathan Cameron
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2018-09-27 19:31 UTC (permalink / raw)
To: ryang
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Mark Rutland, linux-iio, devicetree,
linux-kernel
On Sat, Sep 22, 2018 at 05:05:38PM -0400, ryang wrote:
> Document device tree bindings for ROHM BH1750 ambient light sensor driver.
>
> Signed-off-by: ryang <decatf@gmail.com>
> ---
> .../devicetree/bindings/iio/light/bh1750.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.txt b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> new file mode 100644
> index 000000000000..468350cc7af6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> @@ -0,0 +1,18 @@
> +ROHM BH1750 - ALS, Ambient light sensor
> +
> +Required properties:
> +
> +- compatible: Must be one of:
> + "rohm,bh1710"
> + "rohm,bh1715"
> + "rohm,bh1721"
> + "rohm,bh1750"
> + "rohm,bh1751"
> +- reg: the I2C address of the sensor
> +
> +Example:
> +
> +bh1750@23 {
light-sensor@23
Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
> + compatible = "rohm,bh1750";
> + reg = <0x23>;
> +};
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation
2018-09-27 19:31 ` [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation Rob Herring
@ 2018-09-29 11:26 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2018-09-29 11:26 UTC (permalink / raw)
To: Rob Herring
Cc: ryang, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Mark Rutland, linux-iio, devicetree, linux-kernel
On Thu, 27 Sep 2018 14:31:37 -0500
Rob Herring <robh@kernel.org> wrote:
> On Sat, Sep 22, 2018 at 05:05:38PM -0400, ryang wrote:
> > Document device tree bindings for ROHM BH1750 ambient light sensor driver.
> >
> > Signed-off-by: ryang <decatf@gmail.com>
> > ---
> > .../devicetree/bindings/iio/light/bh1750.txt | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.txt b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> > new file mode 100644
> > index 000000000000..468350cc7af6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> > @@ -0,0 +1,18 @@
> > +ROHM BH1750 - ALS, Ambient light sensor
> > +
> > +Required properties:
> > +
> > +- compatible: Must be one of:
> > + "rohm,bh1710"
> > + "rohm,bh1715"
> > + "rohm,bh1721"
> > + "rohm,bh1750"
> > + "rohm,bh1751"
> > +- reg: the I2C address of the sensor
> > +
> > +Example:
> > +
> > +bh1750@23 {
>
> light-sensor@23
>
> Otherwise,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Fixed up. Thanks Rob.
Jonathan
>
> > + compatible = "rohm,bh1750";
> > + reg = <0x23>;
> > +};
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation
@ 2018-09-22 20:57 ryang
2018-09-22 20:57 ` [PATCH v3 2/2] iio: light: bh1750: Add device tree support ryang
0 siblings, 1 reply; 6+ messages in thread
From: ryang @ 2018-09-22 20:57 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Rob Herring, Mark Rutland, linux-iio, devicetree, linux-kernel,
ryang
Document device tree bindings for ROHM BH1750 ambient light sensor driver.
Signed-off-by: ryang <decatf@gmail.com>
---
.../devicetree/bindings/iio/light/bh1750.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.txt b/Documentation/devicetree/bindings/iio/light/bh1750.txt
new file mode 100644
index 000000000000..468350cc7af6
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/bh1750.txt
@@ -0,0 +1,18 @@
+ROHM BH1750 - ALS, Ambient light sensor
+
+Required properties:
+
+- compatible: Must be one of:
+ "rohm,bh1710"
+ "rohm,bh1715"
+ "rohm,bh1721"
+ "rohm,bh1750"
+ "rohm,bh1751"
+- reg: the I2C address of the sensor
+
+Example:
+
+bh1750@23 {
+ compatible = "rohm,bh1750";
+ reg = <0x23>;
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v3 2/2] iio: light: bh1750: Add device tree support
2018-09-22 20:57 ryang
@ 2018-09-22 20:57 ` ryang
2018-09-24 20:10 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: ryang @ 2018-09-22 20:57 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Rob Herring, Mark Rutland, linux-iio, devicetree, linux-kernel,
ryang
Add device tree support for ROHM BH1750 series ambient light sensors.
Signed-off-by: ryang <decatf@gmail.com>
---
Changes in v2:
- Export module device table
Changes in v3:
- Remove of_match_ptr so that bh1750_of_match is available
without CONFIG_OF.
drivers/iio/light/bh1750.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c
index c3a481452b67..28347df78cff 100644
--- a/drivers/iio/light/bh1750.c
+++ b/drivers/iio/light/bh1750.c
@@ -307,9 +307,20 @@ static const struct i2c_device_id bh1750_id[] = {
};
MODULE_DEVICE_TABLE(i2c, bh1750_id);
+static const struct of_device_id bh1750_of_match[] = {
+ { .compatible = "rohm,bh1710", },
+ { .compatible = "rohm,bh1715", },
+ { .compatible = "rohm,bh1721", },
+ { .compatible = "rohm,bh1750", },
+ { .compatible = "rohm,bh1751", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, bh1750_of_match);
+
static struct i2c_driver bh1750_driver = {
.driver = {
.name = "bh1750",
+ .of_match_table = bh1750_of_match,
.pm = &bh1750_pm_ops,
},
.probe = bh1750_probe,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/2] iio: light: bh1750: Add device tree support
2018-09-22 20:57 ` [PATCH v3 2/2] iio: light: bh1750: Add device tree support ryang
@ 2018-09-24 20:10 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2018-09-24 20:10 UTC (permalink / raw)
To: ryang
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Rob Herring, Mark Rutland, linux-iio, devicetree, linux-kernel
On Sat, 22 Sep 2018 16:57:54 -0400
ryang <decatf@gmail.com> wrote:
> Add device tree support for ROHM BH1750 series ambient light sensors.
>
> Signed-off-by: ryang <decatf@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> Changes in v2:
> - Export module device table
> Changes in v3:
> - Remove of_match_ptr so that bh1750_of_match is available
> without CONFIG_OF.
>
> drivers/iio/light/bh1750.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c
> index c3a481452b67..28347df78cff 100644
> --- a/drivers/iio/light/bh1750.c
> +++ b/drivers/iio/light/bh1750.c
> @@ -307,9 +307,20 @@ static const struct i2c_device_id bh1750_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, bh1750_id);
>
> +static const struct of_device_id bh1750_of_match[] = {
> + { .compatible = "rohm,bh1710", },
> + { .compatible = "rohm,bh1715", },
> + { .compatible = "rohm,bh1721", },
> + { .compatible = "rohm,bh1750", },
> + { .compatible = "rohm,bh1751", },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, bh1750_of_match);
> +
> static struct i2c_driver bh1750_driver = {
> .driver = {
> .name = "bh1750",
> + .of_match_table = bh1750_of_match,
> .pm = &bh1750_pm_ops,
> },
> .probe = bh1750_probe,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-29 11:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-22 21:05 [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation ryang
2018-09-22 21:05 ` [PATCH v3 2/2] iio: light: bh1750: Add device tree support ryang
2018-09-27 19:31 ` [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation Rob Herring
2018-09-29 11:26 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2018-09-22 20:57 ryang
2018-09-22 20:57 ` [PATCH v3 2/2] iio: light: bh1750: Add device tree support ryang
2018-09-24 20:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).