From: Thierry Reding <thierry.reding@gmail.com>
To: Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: [PATCH] arm64: amlogic: Rename spi pinmux group
Date: Mon, 24 Sep 2018 11:45:23 +0200 [thread overview]
Message-ID: <20180924094523.20573-1-thierry.reding@gmail.com> (raw)
From: Thierry Reding <treding@nvidia.com>
The name "spi" is reserved for nodes representing an SPI controller.
Rename the "spi" pinmux group to "spi-miso" to avoid the issue and for
consistency with other pinmux groups.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Rob,
do you think perhaps DTC is being a little too strict here? Seems to me
like the check could be limited to nodes that have a name and a unit
address, the assumption being that an SPI controller would always have
some sort of register space that requires a reg property and therefore
also a unit address.
Thierry
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 2 +-
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 98cbba6809ca..3cd4475ca027 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -390,7 +390,7 @@
};
};
- spi_pins: spi {
+ spi_pins: spi-miso {
mux {
groups = "spi_miso",
"spi_mosi",
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index c87a80e9bcc6..911fd3412788 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -337,7 +337,7 @@
};
};
- spi_pins: spi {
+ spi_pins: spi-miso {
mux {
groups = "spi_miso",
"spi_mosi",
--
2.19.0
next reply other threads:[~2018-09-24 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 9:45 Thierry Reding [this message]
2018-09-25 13:53 ` [PATCH] arm64: amlogic: Rename spi pinmux group Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924094523.20573-1-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).