[PATCH] arm64: amd: seattle: Use "spi" as name for SPI controllers

[PATCH] arm64: amd: seattle: Use "spi" as name for SPI controllers

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

Recent versions of DTC contain additional checks for SPI busses and warn
about certain common mistakes, such as when an SPI controller has a name
other than "spi".

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
index 125f4deb52fe..b664e7af74eb 100644
--- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
+++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
@@ -107,7 +107,7 @@
 			clock-names = "uartclk", "apb_pclk";
 		};
 
-		spi0: ssp@e1020000 {
+		spi0: spi@e1020000 {
 			status = "disabled";
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0 0xe1020000 0 0x1000>;
@@ -117,7 +117,7 @@
 			clock-names = "apb_pclk";
 		};
 
-		spi1: ssp@e1030000 {
+		spi1: spi@e1030000 {
 			status = "disabled";
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0 0xe1030000 0 0x1000>;
-- 
2.19.0

Re: [PATCH] arm64: amd: seattle: Use "spi" as name for SPI controllers

[Lendacky, Thomas]

On 09/24/2018 04:46 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Recent versions of DTC contain additional checks for SPI busses and warn
> about certain common mistakes, such as when an SPI controller has a name
> other than "spi".
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Looks like the same patch was already submitted:

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-September/601706.html

Thanks,
Tom

> ---
>  arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
> index 125f4deb52fe..b664e7af74eb 100644
> --- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
> +++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
> @@ -107,7 +107,7 @@
>  			clock-names = "uartclk", "apb_pclk";
>  		};
>  
> -		spi0: ssp@e1020000 {
> +		spi0: spi@e1020000 {
>  			status = "disabled";
>  			compatible = "arm,pl022", "arm,primecell";
>  			reg = <0 0xe1020000 0 0x1000>;
> @@ -117,7 +117,7 @@
>  			clock-names = "apb_pclk";
>  		};
>  
> -		spi1: ssp@e1030000 {
> +		spi1: spi@e1030000 {
>  			status = "disabled";
>  			compatible = "arm,pl022", "arm,primecell";
>  			reg = <0 0xe1030000 0 0x1000>;
> 

Re: [PATCH] arm64: amd: seattle: Use "spi" as name for SPI controllers

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 918 bytes --]

On Mon, Sep 24, 2018 at 01:09:16PM +0000, Lendacky, Thomas wrote:
> On 09/24/2018 04:46 AM, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Recent versions of DTC contain additional checks for SPI busses and warn
> > about certain common mistakes, such as when an SPI controller has a name
> > other than "spi".
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> Looks like the same patch was already submitted:
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-September/601706.html

Indeed. I had done a quick search and not seen these submitted in recent
days and since the DTC change that causes these had only landed in -next
on Friday I had assumed that they must not have been fixed yet.

I wouldn't have thought that Rob had preemptively sent out the fixes.
But it being Rob, maybe I should have. =)

Sorry for the noise,
Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel