devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: iwg20d-q7-common: Move pciec node out of common dtsi
@ 2018-09-21 14:07 Biju Das
  2018-09-24  8:38 ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Biju Das @ 2018-09-21 14:07 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland
  Cc: Biju Das, Simon Horman, Magnus Damm, devicetree,
	linux-renesas-soc, Geert Uytterhoeven, Chris Paterson,
	Fabrizio Castro

PCIe is not populated by default on iWave RZ/G1N board. RZ/G1N board
is almost identical to RZ/G1M. In order to reuse the common dtsi for
both the boards, it is required to move pcie node from common dtsi
to board specific dts.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm/boot/dts/iwg20d-q7-common.dtsi         | 4 ----
 arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts | 4 ++++
 arch/arm/boot/dts/r8a7743-iwg20d-q7.dts         | 4 ++++
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
index 5cae74e..ca9154dd 100644
--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
@@ -160,10 +160,6 @@
 	clock-frequency = <100000000>;
 };
 
-&pciec {
-	status = "okay";
-};
-
 &pfc {
 	can0_pins: can0 {
 		groups = "can0_data_d";
diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
index 3275451..0d006ae 100644
--- a/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
+++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
@@ -14,3 +14,7 @@
 	model = "iW-RainboW-G20D-Q7 RZ/G1M based plus camera daughter board";
 	compatible = "iwave,g20d", "iwave,g20m", "renesas,r8a7743";
 };
+
+&pciec {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
index b683db4..498e223 100644
--- a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
+++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
@@ -13,3 +13,7 @@
 	model = "iWave Systems RainboW-G20D-Qseven board based on RZ/G1M";
 	compatible = "iwave,g20d", "iwave,g20m", "renesas,r8a7743";
 };
+
+&pciec {
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: iwg20d-q7-common: Move pciec node out of common dtsi
  2018-09-21 14:07 [PATCH] ARM: dts: iwg20d-q7-common: Move pciec node out of common dtsi Biju Das
@ 2018-09-24  8:38 ` Simon Horman
  2018-09-25  7:34   ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2018-09-24  8:38 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Magnus Damm, devicetree,
	linux-renesas-soc, Geert Uytterhoeven, Chris Paterson,
	Fabrizio Castro

On Fri, Sep 21, 2018 at 03:07:55PM +0100, Biju Das wrote:
> PCIe is not populated by default on iWave RZ/G1N board. RZ/G1N board
> is almost identical to RZ/G1M. In order to reuse the common dtsi for
> both the boards, it is required to move pcie node from common dtsi
> to board specific dts.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: iwg20d-q7-common: Move pciec node out of common dtsi
  2018-09-24  8:38 ` Simon Horman
@ 2018-09-25  7:34   ` Simon Horman
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2018-09-25  7:34 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Magnus Damm, devicetree,
	linux-renesas-soc, Geert Uytterhoeven, Chris Paterson,
	Fabrizio Castro

On Mon, Sep 24, 2018 at 10:38:51AM +0200, Simon Horman wrote:
> On Fri, Sep 21, 2018 at 03:07:55PM +0100, Biju Das wrote:
> > PCIe is not populated by default on iWave RZ/G1N board. RZ/G1N board
> > is almost identical to RZ/G1M. In order to reuse the common dtsi for
> > both the boards, it is required to move pcie node from common dtsi
> > to board specific dts.
> > 
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.

Thanks again, applied for v4.20.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-25  7:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 14:07 [PATCH] ARM: dts: iwg20d-q7-common: Move pciec node out of common dtsi Biju Das
2018-09-24  8:38 ` Simon Horman
2018-09-25  7:34   ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).