From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Rodrigo Exterckötter Tjäder" <rodrigo@tjader.xyz>
Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC.
Date: Tue, 25 Sep 2018 11:01:39 +0200 [thread overview]
Message-ID: <20180925090139.qbu6tqav5oth7zkw@flea> (raw)
In-Reply-To: <CAG7TQgE_KU_cK_4E+NG8Qcw-QB2=C6YoqBYR2svmWxywFyySCw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
On Fri, Sep 21, 2018 at 11:54:07AM -0300, Rodrigo Exterckötter Tjäder wrote:
> On Fri, Sep 21, 2018 at 11:28 AM Maxime Ripard
> <maxime.ripard@bootlin.com> wrote:
> > Expanding a bit more that commit log would be helpful. What is the
> > eMMC connected to that board? Do all versions have it? Which modes are
> > supposed to be supported, and which one have been tested?
>
> The terseness of the commit message was already pointed out to me on
> #linux-sunxi. I was waiting for more comments before sending a v2.
>
> But you do touch on something I also realized: there are actually
> three versions of the A64-OLinuXino. In fact only one of them has the
> WiFi board, which is already enabled in the current device tree.
Sigh, ok..
> Wouldn't it be better to split it into three separate device trees? I
> have made a patch that does that[1], if you think that is a good
> approach I can submit that as a patch and then later submit a patch on
> top of that to enable the eMMC only on the two boards that have it.
We can't really do that, unfortunately. If the device tree name was to
change for a given board, we'd break all the build systems, boot
scripts and distros out there.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-25 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:18 [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC Rodrigo Exterckötter Tjäder
2018-09-21 14:28 ` Maxime Ripard
2018-09-21 14:54 ` Rodrigo Exterckötter Tjäder
2018-09-25 9:01 ` Maxime Ripard [this message]
2018-09-25 17:47 ` Rodrigo Exterckötter Tjäder
2018-09-27 8:17 ` Maxime Ripard
2018-09-27 14:49 ` Rodrigo Exterckötter Tjäder
2018-09-29 15:47 ` Maxime Ripard
2018-09-29 16:51 ` Rodrigo Exterckötter Tjäder
2018-10-02 13:13 ` Maxime Ripard
2018-10-02 16:47 ` Rodrigo Exterckötter Tjäder
2018-10-05 15:48 ` Maxime Ripard
2018-11-15 14:46 ` Rodrigo Exterckötter Tjäder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925090139.qbu6tqav5oth7zkw@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rodrigo@tjader.xyz \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).