From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH V7 2/2] csky: remove irq_mapping from smp.c. Date: Tue, 25 Sep 2018 17:17:03 +0800 Message-ID: <20180925091702.GA6607@guoren> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Mark Rutland , Rob Herring , Stephen Rothwell , Linux Kernel Mailing List , DTML , linux-arch , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Greentime Hu List-Id: devicetree@vger.kernel.org On Mon, Sep 24, 2018 at 10:23:14PM +0200, Arnd Bergmann wrote: > On Tue, Sep 18, 2018 at 3:48 PM Guo Ren wrote: > > > > - remove irq_mapping from smp.c to irq-driver > > - Add set_ipi_irq_mapping api to irq-driver > > - update asm/smp.h > > > > Signed-off-by: Guo Ren > > The patch seems ok to me, but please try to improve the changelog comments. > Generally speaking, use full English sentences instead of an enumerated list, > and explain what the change is for rather than what you are doing. The text Ok, I'll improve it. > you have here can easily be derived from looking at the code changes, > but I still don't understand what caused you to change it, and why this > is better than the previous version. The changelog comment will change to: There are some feedbacks from irqchip, and we need to adjust "smp.c & smp.h" to match the csky_mptimer modification. - Move IPI_IRQ define into drivers/irqchip/csky_mpintc.c, because it's a interrupt controller specific. - Bugfix request_irq with IPI_IRQ, we must use irq_mapping return value not directly use IPI_IRQ. The modification also involves csky_mpintc. Best Regards Guo Ren