From: Rob Herring <robh@kernel.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-pm@vger.kernel.org, gregkh@linuxfoundation.org,
rjw@rjwysocki.net, mturquette@baylibre.com, khilman@baylibre.com,
vincent.guittot@linaro.org, skannan@codeaurora.org,
bjorn.andersson@linaro.org, amit.kucheria@linaro.org,
seansw@qti.qualcomm.com, daidavid1@codeaurora.org,
evgreen@chromium.org, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com, abailon@baylibre.com,
maxime.ripard@bootlin.com, arnd@arndb.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v9 5/8] interconnect: qcom: Add RPM communication
Date: Tue, 25 Sep 2018 13:17:35 -0500 [thread overview]
Message-ID: <20180925181735.GA28385@bogus> (raw)
In-Reply-To: <20180831140151.13972-6-georgi.djakov@linaro.org>
On Fri, Aug 31, 2018 at 05:01:48PM +0300, Georgi Djakov wrote:
> On some Qualcomm SoCs, there is a remote processor, which controls some of
> the Network-On-Chip interconnect resources. Other CPUs express their needs
> by communicating with this processor. Add a driver to handle communication
> with this remote processor.
I don't think you should have a binding nor a separate driver for this.
It's not actually an interconnect provider, so it doesn't belong in
bindings/interconnect. And it just looks like abuse of DT to instantiate
some driver.
All the driver amounts to is a 1 function wrapper for RPM_KEY_BW
messages. Can't this be part of the parent?
Rob
next prev parent reply other threads:[~2018-09-25 18:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 14:01 [PATCH v9 0/8] Introduce on-chip interconnect API Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 1/8] interconnect: Add generic " Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 2/8] dt-bindings: Introduce interconnect binding Georgi Djakov
2018-09-25 18:02 ` Rob Herring
2018-09-26 14:34 ` Jordan Crouse
2018-10-01 20:56 ` Saravana Kannan
2018-10-01 21:26 ` Jordan Crouse
2018-10-01 21:51 ` Saravana Kannan
2018-09-26 14:42 ` Georgi Djakov
2018-09-26 14:48 ` Sudeep Holla
2018-09-26 15:03 ` Georgi Djakov
2018-10-01 23:49 ` Saravana Kannan
2018-10-02 11:17 ` Sudeep Holla
2018-10-02 18:56 ` Saravana Kannan
2018-10-03 9:33 ` Sudeep Holla
2018-10-03 18:06 ` Saravana Kannan
2018-10-10 15:02 ` Sudeep Holla
2018-11-27 18:05 ` Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 3/8] interconnect: Allow endpoints translation via DT Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 4/8] interconnect: Add debugfs support Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 5/8] interconnect: qcom: Add RPM communication Georgi Djakov
2018-09-25 18:17 ` Rob Herring [this message]
2018-10-02 11:02 ` Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 6/8] dt-bindings: interconnect: Document qcom,msm8916 NoC bindings Georgi Djakov
2018-09-25 18:22 ` Rob Herring
2018-10-02 11:02 ` Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 7/8] interconnect: qcom: Add msm8916 interconnect provider driver Georgi Djakov
2018-08-31 14:01 ` [PATCH v9 8/8] MAINTAINERS: add a maintainer for the interconnect API Georgi Djakov
2018-09-04 10:24 ` [PATCH v9 0/8] Introduce on-chip " Amit Kucheria
2018-09-04 23:36 ` Stephen Rothwell
2018-09-05 14:50 ` Georgi Djakov
2018-09-05 15:05 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925181735.GA28385@bogus \
--to=robh@kernel.org \
--cc=abailon@baylibre.com \
--cc=amit.kucheria@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=seansw@qti.qualcomm.com \
--cc=skannan@codeaurora.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).