From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs Date: Tue, 25 Sep 2018 16:35:50 -0700 Message-ID: <20180925233550.GB27436@tuxbook-pro> References: <20180920172237.30965-1-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sibi Sankar Cc: Ohad Ben-Cohen , Rob Herring , Mark Rutland , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel-owner@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue 25 Sep 03:18 PDT 2018, Sibi Sankar wrote: > On 2018-09-20 22:52, Bjorn Andersson wrote: > > diff --git a/drivers/remoteproc/qcom_adsp_pil.c > > b/drivers/remoteproc/qcom_adsp_pil.c > > index da2254ea1135..fcbb816a9698 100644 > > --- a/drivers/remoteproc/qcom_adsp_pil.c > > +++ b/drivers/remoteproc/qcom_adsp_pil.c > > @@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init = > > { > > .ssctl_id = 0x16, > > }; > > > > +static const struct adsp_data wcss_resource_init = { > > + .crash_reason_smem = 421, > > + .firmware_name = "wcnss.mdt", > > + .pas_id = 6, > > + .ssr_name = "mpss", > > + .sysmon_name = "wlan", > > Shouldn't the sysmon name be "wcnss" instead of "wlan"? > I derived this from the downstream kernel, perhaps I got it wrong? Regards, Bjorn