From: Marco Felsch <m.felsch@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
"Andreas Färber" <afaerber@suse.de>,
robh+dt@kernel.org, kernel@pengutronix.de,
"Javier Martinez Canillas" <javier.martinez@collabora.co.uk>,
"Tushar Behera" <tushar.behera@linaro.org>
Subject: Re: [PATCH 4/5] ASoC: max98088: Add master clock handling
Date: Wed, 26 Sep 2018 14:30:09 +0200 [thread overview]
Message-ID: <20180926123009.yvwiupg56eu4llbb@pengutronix.de> (raw)
In-Reply-To: <20180926122249.GV20825@sirena.org.uk>
On 18-09-26 13:22, Mark Brown wrote:
> On Wed, Sep 26, 2018 at 12:00:30PM +0200, Marco Felsch wrote:
>
> > One question, should it optional or not? If not I will fix it to return
> > the clk_get error else I will drop it. It shouldn't be optional In my
> > point of view, since it is needed by the chip.
>
> Optional seems safer, requiring the clock isn't going to work so well on
> ACPI systems.
Okay, I will integrate it in my v2.
next prev parent reply other threads:[~2018-09-26 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 14:23 [PATCH 0/5] MAX98088/9 of features Marco Felsch
2018-09-25 14:23 ` [PATCH 1/5] ASoC: dt-bindings: add max98088 audio codec Marco Felsch
2018-09-25 14:23 ` [PATCH 2/5] ASoC: max98088: add OF support Marco Felsch
2018-09-25 17:11 ` Mark Brown
2018-09-26 10:42 ` Marco Felsch
2018-09-25 14:23 ` [PATCH 3/5] ASoC: dt-bindings: max98088: add external clock binding Marco Felsch
2018-09-25 14:23 ` [PATCH 4/5] ASoC: max98088: Add master clock handling Marco Felsch
2018-09-25 17:17 ` Mark Brown
2018-09-26 10:00 ` Marco Felsch
2018-09-26 12:22 ` Mark Brown
2018-09-26 12:30 ` Marco Felsch [this message]
2018-09-25 14:23 ` [PATCH 5/5] ASoC: max98988: make it selectable Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926123009.yvwiupg56eu4llbb@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=afaerber@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).