devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: paz00: fix wakeup gpio keycode
@ 2018-08-02  8:45 Marc Dietrich
  2018-08-21 16:00 ` Nicolas Chauvet
  2018-09-26 15:30 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Marc Dietrich @ 2018-08-02  8:45 UTC (permalink / raw)
  To: Thierry Reding; +Cc: devicetree, linux-tegra, Marc Dietrich

The power key is controlled solely by the EC, which only tiggeres this
gpio after wakeup.
Fixes immediately return to suspend after wake from LP1.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
---
 arch/arm/boot/dts/tegra20-paz00.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/tegra20-paz00.dts b/arch/arm/boot/dts/tegra20-paz00.dts
index ef245291924f..4f9b4a889feb 100644
--- a/arch/arm/boot/dts/tegra20-paz00.dts
+++ b/arch/arm/boot/dts/tegra20-paz00.dts
@@ -524,10 +524,10 @@
 	gpio-keys {
 		compatible = "gpio-keys";
 
-		power {
-			label = "Power";
+		wakeup {
+			label = "Wakeup";
 			gpios = <&gpio TEGRA_GPIO(J, 7) GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_POWER>;
+			linux,code = <KEY_WAKEUP>;
 			wakeup-source;
 		};
 	};
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: paz00: fix wakeup gpio keycode
  2018-08-02  8:45 [PATCH] ARM: dts: paz00: fix wakeup gpio keycode Marc Dietrich
@ 2018-08-21 16:00 ` Nicolas Chauvet
  2018-09-26 15:30 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Chauvet @ 2018-08-21 16:00 UTC (permalink / raw)
  To: marvin24; +Cc: Thierry Reding, devicetree, linux-tegra

Le jeu. 2 août 2018 à 10:47, Marc Dietrich <marvin24@gmx.de> a écrit :
>
> The power key is controlled solely by the EC, which only tiggeres this
> gpio after wakeup.
> Fixes immediately return to suspend after wake from LP1.
>
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>

Tested-by: Nicolas Chauvet <kwizart@gmail.com>
It was reported to work on the device with a (yet little custom)
distro kernel based on fedora 4.18.1-300.fc28.armv7hl

Thx

-- 
-

Nicolas (kwizart)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: paz00: fix wakeup gpio keycode
  2018-08-02  8:45 [PATCH] ARM: dts: paz00: fix wakeup gpio keycode Marc Dietrich
  2018-08-21 16:00 ` Nicolas Chauvet
@ 2018-09-26 15:30 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2018-09-26 15:30 UTC (permalink / raw)
  To: Marc Dietrich; +Cc: devicetree, linux-tegra

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Thu, Aug 02, 2018 at 10:45:40AM +0200, Marc Dietrich wrote:
> The power key is controlled solely by the EC, which only tiggeres this
> gpio after wakeup.
> Fixes immediately return to suspend after wake from LP1.
> 
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> ---
>  arch/arm/boot/dts/tegra20-paz00.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-26 21:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-02  8:45 [PATCH] ARM: dts: paz00: fix wakeup gpio keycode Marc Dietrich
2018-08-21 16:00 ` Nicolas Chauvet
2018-09-26 15:30 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).