From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet Date: Wed, 26 Sep 2018 19:05:45 +0200 Message-ID: <20180926170545.ogcmt36ff7jmqxkl@flea> References: <20180919141938.18791-1-rodrigo@tjader.xyz> <20180921142941.5ymp7ksphgboxrwz@flea> <20180926094525.e4fepvonmy7ykdbb@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rodrigo =?utf-8?B?RXh0ZXJja8O2dHRlciBUasOkZGVy?= Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Sep 26, 2018 at 12:14:15PM -0300, Rodrigo Exterckötter Tjäder wrote: > On Wed, Sep 26, 2018 at 6:46 AM Maxime Ripard wrote: > > There's no need to be so specific though :) > > > > Something like that would work: > > > > arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay > > > > The PHY found on the A64-Olinuxino requires a TX delay in order to > > operate properly. Olimex uses a 600ps second delay in their BSP, and > > that has been found to work, so let's use that value in the current > > DT. > > Should I go ahead and send a v2 with that commit message then? Yep, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com