From: Rob Herring <robh@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Abel Vesa <abel.vesa@nxp.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
patchwork-lst@pengutronix.de, NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCh v3 2/4] arm64: add basic DTS for i.MX8MQ
Date: Thu, 27 Sep 2018 14:14:50 -0500 [thread overview]
Message-ID: <20180927191450.GA32039@bogus> (raw)
In-Reply-To: <20180921125626.21971-2-l.stach@pengutronix.de>
On Fri, Sep 21, 2018 at 02:56:24PM +0200, Lucas Stach wrote:
> This adds the basic DTS for the i.MX8MQ.
> For now only the following peripherals are supported:
> - IOMUXC (pin controller)
> - CCM (clock controller)
> - GPIO
> - UART
> - uSDHC (SD/eMMC controller)
> - FEC (ethernet controller)
> - i2c
>
> +#define MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x0A8 0x310 0x000 0x0 0x0
> +#define MX8MQ_IOMUXC_SD1_DATA0_GPIO2_IO2 0x0A8 0x31 0x000 0x5 0x0
The 0x31 looks suspicious.
And checkpatch isn't happy about the spaces instead of tabs.
Rob
> +#define MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x0AC 0x314 0x000 0x0 0x0
next prev parent reply other threads:[~2018-09-27 19:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 12:56 [PATCh v3 1/4] arm64: add basic Kconfig symbols for i.MX8 Lucas Stach
2018-09-21 12:56 ` [PATCh v3 2/4] arm64: add basic DTS for i.MX8MQ Lucas Stach
2018-09-26 14:19 ` A.s. Dong
2018-09-27 19:14 ` Rob Herring [this message]
2018-11-12 18:06 ` A.s. Dong
2018-09-21 12:56 ` [PATCh v3 3/4] arm64: add support for i.MX8M EVK board Lucas Stach
2018-09-26 14:29 ` A.s. Dong
2018-09-27 19:16 ` Rob Herring
2018-09-21 12:56 ` [PATCh v3 4/4] MAINTAINERS: add i.MX8 DT path to i.MX architecture Lucas Stach
2018-09-26 14:33 ` A.s. Dong
2018-09-26 12:02 ` [PATCh v3 1/4] arm64: add basic Kconfig symbols for i.MX8 A.s. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927191450.GA32039@bogus \
--to=robh@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=patchwork-lst@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).