devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: linux-omap@vger.kernel.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org, "Dave Gerlach" <d-gerlach@ti.com>,
	"Tero Kristo" <t-kristo@ti.com>
Subject: Re: [PATCH 0/4] Update dra7 dts to probe with ti-sysc
Date: Fri, 28 Sep 2018 10:56:43 -0700	[thread overview]
Message-ID: <20180928175643.GL5662@atomide.com> (raw)
In-Reply-To: <c67f54bb-8995-5d5b-053d-3caa25772b35@ti.com>

* Keerthy <j-keerthy@ti.com> [180928 11:43]:
> I tried [1]. I see gpio throwing some errors while suspending:
> 
> https://pastebin.ubuntu.com/p/92qbWh4rgW/
> 
> [   64.610205] omap_gpio 44e07000.gpio: sysc_child_suspend_noirq busy at
> 1257: -16
> [   64.612509] omap_gpio 48320000.gpio: sysc_child_suspend_noirq busy at
> 1257: -16
> [   64.612754] omap_gpio 481ae000.gpio: sysc_child_suspend_noirq busy at
> 1257: -16

Thanks for testing :) Yeah I'm seeing those warnings too, the system
came up just fine from resume right?

With the gpio notifier changes we now only idle gpio interrupts
from the notifier so in general those warnings are harmless. We
should probably just make these warnings dev_dbg now.

Those warnings should only appear for gpio instances with interrupts
as in grep gpio /proc/interrupts. And we only idle those gpio banks
if a deeper idle state is entered, which is not the case for dra7.

I'm mostly worried that all the devices work as before on dra7
though, like LCD, USB, SATA and so on..

Regards,

Tony

  reply	other threads:[~2018-09-29  0:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 21:05 [PATCH 0/4] Update dra7 dts to probe with ti-sysc Tony Lindgren
2018-09-27 21:05 ` [PATCH 1/4] bus: ti-sysc: Detect timer and gpio on dra7 Tony Lindgren
2018-09-27 21:05 ` [PATCH 2/4] bus: ti-sysc: Detect devices for debug " Tony Lindgren
2018-09-27 21:05 ` [PATCH 3/4] ARM: dts: dra7: Add l4 interconnect hierarchy and ti-sysc data Tony Lindgren
2018-09-27 21:05 ` [PATCH 4/4] ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc Tony Lindgren
2018-09-28 11:38 ` [PATCH 0/4] Update dra7 dts to probe " Keerthy
2018-09-28 17:56   ` Tony Lindgren [this message]
2018-09-28 21:30     ` Grygorii Strashko
2018-09-28 22:32       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928175643.GL5662@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).