From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: ryang <decatf@gmail.com>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation
Date: Sat, 29 Sep 2018 12:26:02 +0100 [thread overview]
Message-ID: <20180929122602.66dde03d@archlinux> (raw)
In-Reply-To: <20180927193137.GA14849@bogus>
On Thu, 27 Sep 2018 14:31:37 -0500
Rob Herring <robh@kernel.org> wrote:
> On Sat, Sep 22, 2018 at 05:05:38PM -0400, ryang wrote:
> > Document device tree bindings for ROHM BH1750 ambient light sensor driver.
> >
> > Signed-off-by: ryang <decatf@gmail.com>
> > ---
> > .../devicetree/bindings/iio/light/bh1750.txt | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.txt b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> > new file mode 100644
> > index 000000000000..468350cc7af6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> > @@ -0,0 +1,18 @@
> > +ROHM BH1750 - ALS, Ambient light sensor
> > +
> > +Required properties:
> > +
> > +- compatible: Must be one of:
> > + "rohm,bh1710"
> > + "rohm,bh1715"
> > + "rohm,bh1721"
> > + "rohm,bh1750"
> > + "rohm,bh1751"
> > +- reg: the I2C address of the sensor
> > +
> > +Example:
> > +
> > +bh1750@23 {
>
> light-sensor@23
>
> Otherwise,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Fixed up. Thanks Rob.
Jonathan
>
> > + compatible = "rohm,bh1750";
> > + reg = <0x23>;
> > +};
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2018-09-29 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 21:05 [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation ryang
2018-09-22 21:05 ` [PATCH v3 2/2] iio: light: bh1750: Add device tree support ryang
2018-09-27 19:31 ` [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation Rob Herring
2018-09-29 11:26 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-22 20:57 ryang
2018-09-24 20:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929122602.66dde03d@archlinux \
--to=jic23@kernel.org \
--cc=decatf@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).