From: Guo Ren <ren_guo@c-sky.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
robh+dt@kernel.org, mark.rutland@arm.com, anurup.m@huawei.com,
Jonathan.Cameron@huawei.com, will.deacon@arm.com,
zhangshaokun@hisilicon.com, jhogan@kernel.org,
paul.burton@mips.com, peterz@infradead.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V10 5/8] clocksource: add C-SKY SMP timer
Date: Fri, 5 Oct 2018 22:03:19 +0800 [thread overview]
Message-ID: <20181005140319.GA6789@guoren-Inspiron-7460> (raw)
In-Reply-To: <4ec284a4-0cff-91b8-bd0a-6eb578b28432@linaro.org>
Hi Daniel,
On Fri, Oct 05, 2018 at 03:48:58PM +0200, Daniel Lezcano wrote:
> On 04/10/2018 19:22, Guo Ren wrote:
> > This timer is used by SMP system and use mfcr/mtcr instruction
> > to access the regs.
> >
> > Changelog:
> > - Add rollback for timer_of_cleanup.
> > - Use request_percpu_irq separate from time_of.
> > - Remove #define CPUHP_AP_CSKY_TIMER_STARTING.
> > - Add CPUHP_AP_CSKY_TIMER_STARTING in cpuhotplug.h.
> > - Support csky mp timer alpha version.
> > - Just use low-counter with 32bit width as clocksource.
> > - Coding convention with upstream feed-back.
> >
> > Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> > ---
> > drivers/clocksource/Kconfig | 10 +++
> > drivers/clocksource/Makefile | 1 +
> > drivers/clocksource/timer-mp-csky.c | 173 ++++++++++++++++++++++++++++++++++++
> > include/linux/cpuhotplug.h | 1 +
> > 4 files changed, 185 insertions(+)
> > create mode 100644 drivers/clocksource/timer-mp-csky.c
> >
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index a11f4ba..826a2e8 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -620,4 +620,14 @@ config RISCV_TIMER
> > is accessed via both the SBI and the rdcycle instruction. This is
> > required for all RISC-V systems.
> >
> > +config CSKY_MP_TIMER
> > + bool "SMP Timer for the C-SKY platform"
> > + depends on CSKY
> > + select TIMER_OF
> > + help
> > + Say yes here to enable C-SKY SMP timer driver used for C-SKY SMP
> > + system.
> > + csky,mptimer is not only used in SMP system, it also could be used
> > + single core system. It's not a mmio reg and it use mtcr/mfcr instruction.
>
>
> ... COMPILE_TEST :)
Ops... I forgot it, should be:
bool "SMP Timer for the C-SKY platform" if COMPILE_TEST
Thx for remind and any other review is welcome.
Best Regards
Guo Ren
next prev parent reply other threads:[~2018-10-05 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 17:22 [PATCH V10 0/8] C-SKY(csky) Linux Kernel Driver Guo Ren
2018-10-04 17:22 ` [PATCH V10 1/8] irqchip: add C-SKY SMP interrupt controller Guo Ren
2018-10-08 16:35 ` Marc Zyngier
2018-10-09 2:24 ` Guo Ren
2018-10-09 8:15 ` Marc Zyngier
2018-10-09 14:59 ` Guo Ren
2018-10-04 17:22 ` [PATCH V10 2/8] dt-bindings: interrupt-controller: C-SKY SMP intc Guo Ren
2018-10-05 20:22 ` Rob Herring
2018-10-04 17:22 ` [PATCH V10 3/8] irqchip: add C-SKY APB bus interrupt controller Guo Ren
2018-10-04 17:22 ` [PATCH V10 4/8] dt-bindings: interrupt-controller: C-SKY APB intc Guo Ren
2018-10-04 17:22 ` [PATCH V10 5/8] clocksource: add C-SKY SMP timer Guo Ren
2018-10-05 13:48 ` Daniel Lezcano
2018-10-05 14:03 ` Guo Ren [this message]
2018-10-04 17:22 ` [PATCH V10 6/8] dt-bindings: timer: C-SKY Multi-processor timer Guo Ren
2018-10-05 20:23 ` Rob Herring
2018-10-04 17:22 ` [PATCH V10 7/8] clocksource: add gx6605s SOC system timer Guo Ren
2018-10-04 17:22 ` [PATCH V10 8/8] dt-bindings: timer: gx6605s SOC timer Guo Ren
2018-10-05 20:21 ` Rob Herring
2018-10-06 10:38 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005140319.GA6789@guoren-Inspiron-7460 \
--to=ren_guo@c-sky.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=anurup.m@huawei.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=paul.burton@mips.com \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).