From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 1/2] dt-bindings: iio: vadc: Update example to include unit address for node 'usb-id-nopull' Date: Fri, 5 Oct 2018 15:47:43 -0500 Message-ID: <20181005204743.GA17135@bogus> References: <20181004001432.21218-1-mka@chromium.org> <20181004001432.21218-2-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181004001432.21218-2-mka@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthias Kaehlcke Cc: Andy Gross , David Brown , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson List-Id: devicetree@vger.kernel.org On Wed, Oct 03, 2018 at 05:14:31PM -0700, Matthias Kaehlcke wrote: > The node has a reg property, therefore its name should include a unit > address. > > Also change the name from 'usb_id_nopull' to 'usb-id-nopull' to follow > DT conventions. This is ADC channels? If so, then DT convention would really be "adc@...". > Signed-off-by: Matthias Kaehlcke > --- > Changes in v4: > - patch added to the series > --- > Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > index d0c188e5c922..ff7aa5038ba6 100644 > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt > @@ -112,7 +112,7 @@ Example: > io-channel-ranges; > > /* Channel node */ > - usb_id_nopull { > + usb-id-nopull@VADC_LR_MUX10_USB_ID { > reg = ; Defines are generally used when there's not well defined numbering such as clock ids. Interrupts and addresses are generally well defined and don't need defines. > qcom,decimation = <512>; > qcom,ratiometric; > -- > 2.19.0.605.g01d371f741-goog >