From: Andrew Lunn <andrew@lunn.ch>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
David Miller <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.
Date: Sun, 7 Oct 2018 20:27:51 +0200 [thread overview]
Message-ID: <20181007182751.GC22794@lunn.ch> (raw)
In-Reply-To: <20181007173823.21590-3-richardcochran@gmail.com>
On Sun, Oct 07, 2018 at 10:38:20AM -0700, Richard Cochran wrote:
> Currently the stack supports time stamping in PHY devices. However,
> there are newer, non-PHY devices that can snoop an MII bus and provide
> time stamps. In order to support such devices, this patch introduces
> a new interface to be used by both PHY and non-PHY devices.
>
> In addition, the one and only user of the old PHY time stamping API is
> converted to the new interface.
Hi Richard
I'm a bit undecided about this. If you look at how we do HWMON sensors
in PHYs, the probe function just registers with the HWMON subsystem.
We don't have any support in phy_device, or anywhere else in the PHY
core.
The mii_timestamper is generic, in the same why hwmon is generic. It
does not matter where the time stamper is. So i'm wondering if we
should remove the special case for a PHY timestamper, remove all the
phylib support, etc.
I need to look at the other patches and see how this all fits
together.
Andrew
next prev parent reply other threads:[~2018-10-07 18:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 17:38 [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface Richard Cochran
2018-10-07 18:27 ` Andrew Lunn [this message]
2018-10-07 19:06 ` Florian Fainelli
2018-10-07 19:15 ` Richard Cochran
2018-10-07 19:54 ` Andrew Lunn
2018-10-07 20:59 ` Richard Cochran
2018-10-07 21:07 ` Richard Cochran
2018-10-07 21:21 ` Andrew Lunn
2018-10-07 21:14 ` Andrew Lunn
2018-10-07 21:20 ` Richard Cochran
2018-10-08 4:39 ` Richard Cochran
2018-10-08 2:04 ` Richard Cochran
2018-10-08 15:07 ` Andrew Lunn
2018-10-08 15:28 ` Richard Cochran
2018-10-08 15:36 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007182751.GC22794@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=mark.rutland@arm.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).