From: Richard Cochran <richardcochran@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
David Miller <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface.
Date: Sun, 7 Oct 2018 21:39:49 -0700 [thread overview]
Message-ID: <20181008043949.vc5atrqutwx3me2c@localhost> (raw)
In-Reply-To: <20181007212033.3qdtkcjlebsdceus@localhost>
On Sun, Oct 07, 2018 at 02:20:33PM -0700, Richard Cochran wrote:
> On Sun, Oct 07, 2018 at 11:14:05PM +0200, Andrew Lunn wrote:
> > I'm currently thinking register_mii_timestamper() should take a netdev
> > argument, and the net_device structure should gain a struct
> > mii_timestamper.
We are going round in circles on this point. V1 had it this way, but
nobody liked it. You specifically asked to move the new pointer out
of the netdev and into phydev.
> > But we have to look at the lifetime problems. A phydev does not know
> > what netdev it is associated to until phy_connect() is called. It is
> > at that point you can call register_mii_timestamper().
I had used a netdev notifier on NETDEV_UP for this, but Florian seemed
to suggest using phy_{connect,attach,disconnect} instead.
Thanks,
Richard
next prev parent reply other threads:[~2018-10-08 4:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 17:38 [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface Richard Cochran
2018-10-07 18:27 ` Andrew Lunn
2018-10-07 19:06 ` Florian Fainelli
2018-10-07 19:15 ` Richard Cochran
2018-10-07 19:54 ` Andrew Lunn
2018-10-07 20:59 ` Richard Cochran
2018-10-07 21:07 ` Richard Cochran
2018-10-07 21:21 ` Andrew Lunn
2018-10-07 21:14 ` Andrew Lunn
2018-10-07 21:20 ` Richard Cochran
2018-10-08 4:39 ` Richard Cochran [this message]
2018-10-08 2:04 ` Richard Cochran
2018-10-08 15:07 ` Andrew Lunn
2018-10-08 15:28 ` Richard Cochran
2018-10-08 15:36 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008043949.vc5atrqutwx3me2c@localhost \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=mark.rutland@arm.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).