* [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0
@ 2018-10-08 11:00 Linus Walleij
2018-10-09 19:26 ` Sam Ravnborg
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2018-10-08 11:00 UTC (permalink / raw)
To: Thierry Reding, dri-devel; +Cc: devicetree
This adds the device tree bindings for the Samsung S6D16D0
panel. This is a command mode only panel using DSI.
Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
.../display/panel/samsung,s6d16d0.txt | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
new file mode 100644
index 000000000000..b94e366f451b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
@@ -0,0 +1,30 @@
+Samsung S6D16D0 4" 864x480 AMOLED panel
+
+Required properties:
+ - compatible: should be:
+ "samsung,s6d16d0",
+ - reg: the virtual channel number of a DSI peripheral
+ - vdd1-supply: I/O voltage supply
+ - reset-gpios: a GPIO spec for the reset pin (active low)
+
+The device node can contain one 'port' child node with one child
+'endpoint' node, according to the bindings defined in
+media/video-interfaces.txt. This node should describe panel's video bus.
+
+Example:
+&dsi {
+ ...
+
+ panel@0 {
+ compatible = "samsung,s6d16d0";
+ reg = <0>;
+ vdd1-supply = <&foo>;
+ reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&dsi_out>;
+ };
+ };
+ };
+};
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0
2018-10-08 11:00 [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0 Linus Walleij
@ 2018-10-09 19:26 ` Sam Ravnborg
2018-10-11 8:48 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Sam Ravnborg @ 2018-10-09 19:26 UTC (permalink / raw)
To: Linus Walleij; +Cc: devicetree, Thierry Reding, dri-devel
On Mon, Oct 08, 2018 at 01:00:05PM +0200, Linus Walleij wrote:
> This adds the device tree bindings for the Samsung S6D16D0
> panel. This is a command mode only panel using DSI.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../display/panel/samsung,s6d16d0.txt | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
> new file mode 100644
> index 000000000000..b94e366f451b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
> @@ -0,0 +1,30 @@
> +Samsung S6D16D0 4" 864x480 AMOLED panel
> +
> +Required properties:
> + - compatible: should be:
> + "samsung,s6d16d0",
> + - reg: the virtual channel number of a DSI peripheral
> + - vdd1-supply: I/O voltage supply
> + - reset-gpios: a GPIO spec for the reset pin (active low)
That it is active low is part of the GPIO part and should not
be mandated as part of the binding?
> +
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in
> +media/video-interfaces.txt. This node should describe panel's video bus.
> +
> +Example:
> +&dsi {
> + ...
> +
> + panel@0 {
> + compatible = "samsung,s6d16d0";
> + reg = <0>;
> + vdd1-supply = <&foo>;
> + reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>;
This line specifies if ACTIVE HIGH or LOW.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0
2018-10-09 19:26 ` Sam Ravnborg
@ 2018-10-11 8:48 ` Linus Walleij
2018-10-11 8:59 ` Andrzej Hajda
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2018-10-11 8:48 UTC (permalink / raw)
To: sam
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
thierry.reding@gmail.com, open list:DRM PANEL DRIVERS
On Tue, Oct 9, 2018 at 9:26 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> On Mon, Oct 08, 2018 at 01:00:05PM +0200, Linus Walleij wrote:
> > + - reset-gpios: a GPIO spec for the reset pin (active low)
>
> That it is active low is part of the GPIO part and should not
> be mandated as part of the binding?
The fact that the consumer requires the line to be asserted
low is an electronic property of the component, i.e. the panel,
and it is just there explaining that if you set it to anything else than
active low, you are probably doing something wrong.
Should I specify "must be set as active low" instead to make
it clear?
> > + reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>;
>
> This line specifies if ACTIVE HIGH or LOW.
Yep we always specify that on the consumer side. Or we should
always do that ... but since this panel is by defintion expecting
an active low signal, anything else would be an error and that
is what I am trying to say in the description.
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0
2018-10-11 8:48 ` Linus Walleij
@ 2018-10-11 8:59 ` Andrzej Hajda
0 siblings, 0 replies; 4+ messages in thread
From: Andrzej Hajda @ 2018-10-11 8:59 UTC (permalink / raw)
To: Linus Walleij, sam
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
thierry.reding@gmail.com, open list:DRM PANEL DRIVERS
On 11.10.2018 10:48, Linus Walleij wrote:
> On Tue, Oct 9, 2018 at 9:26 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>> On Mon, Oct 08, 2018 at 01:00:05PM +0200, Linus Walleij wrote:
>>> + - reset-gpios: a GPIO spec for the reset pin (active low)
>> That it is active low is part of the GPIO part and should not
>> be mandated as part of the binding?
> The fact that the consumer requires the line to be asserted
> low is an electronic property of the component, i.e. the panel,
> and it is just there explaining that if you set it to anything else than
> active low, you are probably doing something wrong.
>
> Should I specify "must be set as active low" instead to make
> it clear?
Common practice is as you wrote, I think it is OK.
Regards
Andrzej
>
>>> + reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>;
>> This line specifies if ACTIVE HIGH or LOW.
> Yep we always specify that on the consumer side. Or we should
> always do that ... but since this panel is by defintion expecting
> an active low signal, anything else would be an error and that
> is what I am trying to say in the description.
>
> Yours,
> Linus Walleij
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-11 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-08 11:00 [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0 Linus Walleij
2018-10-09 19:26 ` Sam Ravnborg
2018-10-11 8:48 ` Linus Walleij
2018-10-11 8:59 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).