From: Vinod <vkoul@kernel.org>
To: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings
Date: Tue, 9 Oct 2018 14:27:57 +0530 [thread overview]
Message-ID: <20181009085757.GI2372@vkoul-mobl> (raw)
In-Reply-To: <5d7a218c-9e96-3931-88ab-0b4dcb3ec4e5@st.com>
Hi Pierre,
On 09-10-18, 09:18, Pierre Yves MORDRET wrote:
> >> * DMA client
> >> @@ -68,7 +84,16 @@ channel: a phandle to the DMA controller plus the following four integer cells:
> >> 0x1: 1/2 full FIFO
> >> 0x2: 3/4 full FIFO
> >> 0x3: full FIFO
> >> -
> >> + -bit 2: Intermediate M2M transfer from/to DDR to/from SRAM throughout MDMA
> >> + 0: MDMA not used to generate an intermediate M2M transfer
> >> + 1: MDMA used to generate an intermediate M2M transfer.
> >> + -bit 3-4: indicated SRAM Buffer size in (2^order)*PAGE_SIZE.
> >> + PAGE_SIZE is given by Linux at 4KiB: include/asm-generic/page.h.
> >> + Order is given by those 2 bits starting at 0.
> >> + Valid only whether Intermediate M2M transfer is set.
> >
> > why do we need this as a property?
>
> In some UC, we need more than 4KiB in case of chaining for better performances.
> Chaining has to be enabled by client if performance is at sacks.
Okay if that is the case why is the user not taking care of this?
Creating DMA txn and chaining them up and starting the chain? Why would
dmaengine driver need to do that?
--
~Vinod
next prev parent reply other threads:[~2018-10-09 8:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 13:01 [PATCH v3 0/7] Add-DMA-MDMA-chaining-support Pierre-Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings Pierre-Yves MORDRET
2018-10-07 14:57 ` Vinod
2018-10-09 7:18 ` Pierre Yves MORDRET
2018-10-09 8:57 ` Vinod [this message]
2018-10-09 13:46 ` Pierre Yves MORDRET
2018-10-12 14:42 ` Rob Herring
2018-09-28 13:01 ` [PATCH v3 2/7] dt-bindings: stm32-dmamux: Add one cell to support DMA/MDMA chain Pierre-Yves MORDRET
2018-10-07 14:58 ` Vinod
2018-10-09 7:22 ` Pierre Yves MORDRET
2018-10-12 14:46 ` Rob Herring
2018-09-28 13:01 ` [PATCH v3 3/7] dt-bindings: stm32-mdma: Add DMA/MDMA chaining support bindings Pierre-Yves MORDRET
2018-10-07 14:59 ` Vinod
2018-10-09 8:17 ` Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 4/7] dmaengine: stm32-dma: Add DMA/MDMA chaining support Pierre-Yves MORDRET
2018-10-07 16:00 ` Vinod
2018-10-09 8:40 ` Pierre Yves MORDRET
2018-10-10 4:03 ` Vinod
2018-10-10 7:02 ` Pierre Yves MORDRET
2018-10-15 17:14 ` Vinod
2018-10-16 9:19 ` Pierre Yves MORDRET
2018-10-16 14:44 ` Vinod
2018-10-19 9:21 ` Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 5/7] dmaengine: stm32-mdma: " Pierre-Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 6/7] dmaengine: stm32-dma: enable descriptor_reuse Pierre-Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 7/7] dmaengine: stm32-mdma: " Pierre-Yves MORDRET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009085757.GI2372@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox