From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org, Kumar Gala <galak@codeaurora.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 11/14] mtd: maps: Merge physmap_of.c into physmap-core.c
Date: Tue, 9 Oct 2018 09:06:54 +0200 [thread overview]
Message-ID: <20181009090654.44e54b3e@bbrezillon> (raw)
In-Reply-To: <CAPybu_1AA-fqSdS_+S=D8XEMaHs9SyECsf1SWq7cRBF8Z3oOzQ@mail.gmail.com>
Hi Ricardo,
On Tue, 9 Oct 2018 08:58:40 +0200
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote:
> > +
> > +static int physmap_flash_probe(struct platform_device *dev)
> > +{
> > struct physmap_flash_info *info;
> > const char * const *probe_type;
> > - const char * const *part_types;
> > int err = 0;
> > int i;
> >
> > - physmap_data = dev_get_platdata(&dev->dev);
> > - if (!physmap_data)
> > - return -ENODEV;
> > + if (!dev->dev.of_node && dev_get_platdata(&dev->dev))
> > + return -EINVAL;
>
> Maybe you want:
> if (!dev->dev.of_node && !dev_get_platdata(&dev->dev))
Yes, I'll fix that.
> >
> > info = devm_kzalloc(&dev->dev, sizeof(*info), GFP_KERNEL);
> > if (!info)
> > @@ -132,14 +341,15 @@ static int physmap_flash_probe(struct platform_device *dev)
> > if (!info->mtds)
> > return -ENOMEM;
> >
> > - if (physmap_data->init) {
> > - err = physmap_data->init(dev);
> > - if (err)
> > - goto err_out;
> > - }
> > -
> > platform_set_drvdata(dev, info);
> >
> > + err = physmap_flash_of_init(dev);
> > + if (err)
> > + err = physmap_flash_pdata_init(dev);
> > +
>
> Maybe replace this with:
> if (dev->dev.of_node)
> err = physmap_flash_of_init(dev);
> else
> err = physmap_flash_pdata_init(dev);
>
> Otherwise we are hiding the returncode from of_init, which might be
> defered probing.
Will fix that one too.
Thanks for your review.
Boris
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2018-10-09 7:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 20:10 [PATCH 00/14] mtd: maps: physmap cleanups Boris Brezillon
2018-10-08 20:10 ` [PATCH 01/14] mtd: maps: physmap: Add SPDX header Boris Brezillon
2018-10-08 20:10 ` [PATCH 02/14] mtd: maps: physmap: Rename ->map and ->mtd into ->maps and ->mtds Boris Brezillon
2018-10-08 20:10 ` [PATCH 03/14] mtd: maps: physmap: Use platform_get_resource() to retrieve iomem resources Boris Brezillon
2018-10-09 7:16 ` Ricardo Ribalda Delgado
2018-10-09 7:54 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 04/14] mtd: maps: physmap: Use dev_notice() and a %pR specifier Boris Brezillon
2018-10-08 20:10 ` [PATCH 05/14] mtd: maps: physmap: Use devm_ioremap_resource() Boris Brezillon
2018-10-08 20:10 ` [PATCH 06/14] mtd: maps: physmap: Remove the MAX_RESOURCES limitation Boris Brezillon
2018-10-09 7:31 ` Ricardo Ribalda Delgado
2018-10-09 7:53 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 07/14] mtd: maps: physmap: Check mtd_device_{parse_register, unregister}() ret code Boris Brezillon
2018-10-08 20:10 ` [PATCH 08/14] mtd: maps: physmap: Return -ENOMEM directly when info allocation fails Boris Brezillon
2018-10-08 20:10 ` [PATCH 09/14] mtd: maps: physmap: Fix coding style issues reported by checkpatch Boris Brezillon
2018-10-09 7:37 ` Ricardo Ribalda Delgado
2018-10-09 7:52 ` Boris Brezillon
2018-10-14 7:26 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 10/14] mtd: maps: Prepare merging of physmap and physmap_of Boris Brezillon
2018-10-08 20:10 ` [PATCH 11/14] mtd: maps: Merge physmap_of.c into physmap-core.c Boris Brezillon
2018-10-09 6:58 ` Ricardo Ribalda Delgado
2018-10-09 7:06 ` Boris Brezillon [this message]
2018-10-08 20:10 ` [PATCH 12/14] mtd: maps: Merge gpio-addr-flash.c " Boris Brezillon
2018-10-09 7:04 ` Ricardo Ribalda Delgado
2018-10-09 7:11 ` Boris Brezillon
2018-10-14 7:06 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 13/14] mtd: maps: Rename physmap_of_{versatile, gemini} into physmap-{versatile, gemini} Boris Brezillon
2018-10-08 20:10 ` [PATCH 14/14] dt-binding: mtd: physmap: Document the addr-gpios property Boris Brezillon
2018-10-09 7:43 ` Ricardo Ribalda Delgado
2018-10-09 7:56 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009090654.44e54b3e@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ricardo.ribalda@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).